Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide --all flag for plugin group get #559

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

marckhouzam
Copy link
Contributor

What this PR does / why we need it

Following the improvements to the output of tanzu plugin group get --all from #526 , this PR makes the --all flag un-hidden.

Which issue(s) this PR fixes

Fixes # N/A

Describe testing done for PR

# Notice the --all flag in the help
$ tz plugin group get  -h
Get the content of the specified plugin-group.  A plugin-group provides a list of plugin name/version combinations which can be installed in one step.  This command allows to see the list of plugins included in the specified group.

Usage:
tanzu plugin group get GROUP_NAME [flags]

Flags:
      --all             include the contextual plugins
  -h, --help            help for get
  -o, --output string   output format (yaml|json|table)

# Notice that shell completion now suggest the --all flag since it no longer hidden 
$ tz plugin group get vmware-tkg/default -<TAB>
--all         -- include the contextual plugins
--help    -h  -- help for get
--output  -o  -- output format (yaml|json|table)

Release note

Make the `--all` flag of `tanzu plugin group get` not hidden.

Additional information

Special notes for your reviewer

Signed-off-by: Marc Khouzam <kmarc@vmware.com>
Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@marckhouzam marckhouzam merged commit 9ca6f39 into vmware-tanzu:main Oct 20, 2023
7 checks passed
@marckhouzam marckhouzam deleted the feat/visibleAllFlag branch October 20, 2023 15:56
@marckhouzam marckhouzam added this to the 1.1.0 milestone Oct 20, 2023
@marckhouzam marckhouzam added the docs-impact issues with documentation impact label Oct 24, 2023
mpanchajanya pushed a commit that referenced this pull request Oct 24, 2023
Signed-off-by: Marc Khouzam <kmarc@vmware.com>
(cherry picked from commit 9ca6f39)
mpanchajanya pushed a commit that referenced this pull request Oct 24, 2023
Signed-off-by: Marc Khouzam <kmarc@vmware.com>
(cherry picked from commit 9ca6f39)
mpanchajanya pushed a commit that referenced this pull request Oct 24, 2023
Signed-off-by: Marc Khouzam <kmarc@vmware.com>
(cherry picked from commit 9ca6f39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required docs-impact issues with documentation impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants