-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX update for context create
and context use
to list plugins will be installed
#563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I was curious if we wanted to do the same for
tanzu context create
?
2.SyncPluginsForContextType
is no longer used anywhere
|
4ca968c
to
22cf8a8
Compare
So why are we keeping that function if it is not used? |
e0bde94
to
78f6881
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another very nice improvement. Thanks!
- Please add some release notes in the PR description.
- I still think doing this change for
tanzu context create
is just as important. I think it is a one line change? What do you think
Removed it. |
Done |
b4d92d2
to
3540052
Compare
6fd8ddf
to
eb9c974
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @chandrareddyp
(cherry picked from commit c8c3ee1)
(cherry picked from commit c8c3ee1)
(cherry picked from commit c8c3ee1)
context create
and context use
to list plugins will be installed
What this PR does / why we need it
Before this change, the
tanzu context create context-name
andtanzu context use context-name
commands created and activated the given context and installed the required plugins. However, they did not list all the plugins they would install as part of the command execution, resulting in a suboptimal user experience. Users were unaware of how many plugins would be installed or which ones were included. Sometimes, the installation process took a considerable amount of time, leaving users in the dark about the installation progress.After this PR, the
tanzu context create context-name
andtanzu context use context-name
commands will list the plugins they are going to install. This enhancement provides a great user experience, as users will know in advance which plugins are being installed. This makes it easier for users to track the progress.Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer