Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'plugin delete' with 'plugin uninstall' #575

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

marckhouzam
Copy link
Contributor

What this PR does / why we need it

With #549 the CLI has moved to use tanzu plugin uninstall over tanzu plugin delete (which is kept as an alias for backwards-compatibility.

In certain PRs following #549 I didn't think to make the change in terminology.

This PR replaces the remaining plugin delete with plugin uninstall

Which issue(s) this PR fixes

Fixes # N/A

Describe testing done for PR

CI

Release note

Replace a few remaining mention of `tanzu plugin delete` with `tanzu plugin uninstall`.

Additional information

Special notes for your reviewer

@marckhouzam marckhouzam requested a review from a team as a code owner October 25, 2023 14:37
@marckhouzam marckhouzam added this to the v1.1.0 milestone Oct 30, 2023
Signed-off-by: Marc Khouzam <kmarc@vmware.com>
Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marckhouzam for fixing this. LGTM.

@marckhouzam marckhouzam merged commit 5d67b4e into vmware-tanzu:main Oct 30, 2023
7 checks passed
@marckhouzam marckhouzam deleted the fix/deleteUninstall branch October 30, 2023 22:00
mpanchajanya pushed a commit that referenced this pull request Nov 1, 2023
Signed-off-by: Marc Khouzam <kmarc@vmware.com>
(cherry picked from commit 5d67b4e)
mpanchajanya pushed a commit that referenced this pull request Nov 1, 2023
Signed-off-by: Marc Khouzam <kmarc@vmware.com>
(cherry picked from commit 5d67b4e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants