Enable previously disabled linters like nakedret, revive unparam, gosec from golang-cli.yml #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpanchajanya
force-pushed
the
fix_linters
branch
from
de25329
to
f451f21
Compare
mpanchajanya
changed the title
mpanchajanya
force-pushed
the
fix_linters
branch
from
f451f21
to
a62ee4b
Compare
prkalle
reviewed
Jan 17, 2024
| @@ -66,6 +66,7 @@ func convertVersionToStringArray(arrOsArchInfo []osArch) []string { | |||
| return oa | |||
| } | |||
|
|
|||
| //nolint:unparam | |||
There was a problem hiding this comment.
Is it a false positive? I see all the params are being used.
There was a problem hiding this comment.
I have disabled because of the error cmd/plugin/builder/command/publish/helper_test.go:69:48: createDummyArtifactDir-pluginNamealways receives"fake-plugin-foo"(unparam)
anujc25
approved these changes
Jan 17, 2024
|
I'm removing myself as a reviewer due to time constraints. |
marckhouzam
added
the
kind/cleanup
mpanchajanya
force-pushed
the
fix_linters
branch
from
a62ee4b
to
30f3d39
Compare
vuil
pushed a commit
to vuil/tanzu-cli
that referenced
this pull request
Jan 23, 2024
…ec from golang-cli.yml (vmware-tanzu#647) * Fix nakedret, revive lint issues * Enable unparam linter * Enable gosec g601 and g602 linters
vuil
pushed a commit
that referenced
this pull request
Jan 23, 2024
…ec from golang-cli.yml (#647) * Fix nakedret, revive lint issues * Enable unparam linter * Enable gosec g601 and g602 linters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
make lint- no issuesRelease note
Additional information
Special notes for your reviewer