Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show details reminder in group search output #649

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

vuil
Copy link
Contributor

@vuil vuil commented Jan 17, 2024

What this PR does / why we need it

Shows a notes at the bottom of the group search tabular output about using the --show-details flag to see all versions of the groups.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Added unit tests.

Output changes are as follows:

> tanzu plugin group search
  GROUP                       DESCRIPTION                          LATEST
  vmware-tanzucli/essentials  Essential plugins for the Tanzu CLI  v1.0.0
  vmware-tap/default          Plugins for TAP                      v1.7.3
  vmware-tkg/default          Plugins for TKG                      v2.4.1
  vmware-tmc/default          Plugins for TMC                      v1.0.0

Note: to view all plugin group versions available, use 'tanzu plugin group search --show-details'
>

Release note

Added note in "tanzu plugin group search" about using --show-details to see all versions of groups 

Additional information

Special notes for your reviewer

@vuil vuil requested a review from a team as a code owner January 17, 2024 17:35
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, and the release notes sentence seems either incomplete or has an extra in at the end.

Besides that LGTM

pkg/command/plugin_group.go Outdated Show resolved Hide resolved
Signed-off-by: Vui Lam <vui.lam@broadcom.com>
@vuil vuil force-pushed the plugin-group-search-show-details-msg branch from 131087e to 0b43d7e Compare January 18, 2024 16:56
@marckhouzam marckhouzam added this to the v1.2.0 milestone Jan 18, 2024
@marckhouzam marckhouzam added the kind/feature Categorizes issue or PR as related to a new feature label Jan 18, 2024
@vuil vuil merged commit ed1b71f into vmware-tanzu:main Jan 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants