Add cliplugins package build scripts, e2e tests #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuil
force-pushed
the
topic/vuichiap/crd_e2e
branch
from
a12221d
to
777ace7
Compare
Signed-off-by: Vui Lam <vui.lam@broadcom.com>
Signed-off-by: Vui Lam <vui.lam@broadcom.com>
- configure crd image used
- add gcloud account setup for accessing gcr.io
- but make workflow to ignore test if missing service account secret
When the workflow is run from fork, which does not have access to
secrets in the main repo, noop the set up of the gcloud CLI, which
is fine since the tests that requires it will be skipped for the
same reasons anyway.
Signed-off-by: Vui Lam <vui.lam@broadcom.com>
anujc25
reviewed
Feb 13, 2024
There was a problem hiding this comment.
Here we are using the root level package directory to store the CLIPlugin package.
If we have a new package in the future, should we consider having a directory structure like packages/cliplugin.cli.tanzu.vmware.com/ to host all the cliplugin package-related yaml files?
Adds an e2e test that performs plugin sync using crd package built from the package/cliplugin.cli.tanzu.vmware.com directory. The specific test requires an envvar CRD_PACKAGE_IMAGE to be set and pointing to a registry location that the test has push permissions on. Also adds build-crd-package.sh that will conditionally build and publish the CRD package if CRD_PACKAGE_IMAGE is set. Signed-off-by: Vui Lam <vui.lam@broadcom.com>
vuil
force-pushed
the
topic/vuichiap/crd_e2e
branch
from
94e8493
to
10a47a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add e2e tests to perform plugins syncing operations using the cliplugins crd package.
Note:
CRD_PACKAGE_IMAGE envvar has to be set to a pushable image location for the added test to be exercised.
CI pipeline has been updated with the values needed.
Added new tools dependencies (yq, ytt, kctl, kbld, vendir)
PR created from branch in main repo instead of fork so as to pick up secrets required in the added e2e tests (they are skipped otherwise)
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
verify that the new test is skipped
verify that the new test is exercised and passes
Release note
Additional information
Special notes for your reviewer