Cleanup logic for skipping essential plugins #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Khouzam <marc.khouzam@broadcom.com>
marckhouzam
requested review from
anujc25 and
mpanchajanya
and removed request for
anujc25 and
mpanchajanya
mpanchajanya
approved these changes
Mar 15, 2024
marckhouzam
commented
Mar 16, 2024
|
|
||
| // Prompt for CEIP agreement | ||
| if !shouldSkipPrompts(cmd) { |
There was a problem hiding this comment.
Join the two identical ifs
| if err := cliconfig.ConfigureCEIPOptIn(); err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| // Install or update essential plugins | ||
| InstallEssentialPlugins(cmd) | ||
| if !shouldSkipEssentialPlugins(cmd) { |
There was a problem hiding this comment.
Follow the same pattern as the checks above.
| "tanzu plugin clean", | ||
| // Avoid trying to install essential plugins when the user initializes or updates the plugin | ||
| // source information since the essential plugins installation would use the old plugin source | ||
| "tanzu plugin source", |
There was a problem hiding this comment.
No change in the list of commands, just fixed the comments and used isSkipCommand() below instead of having code duplication.
vuil
pushed a commit
to vuil/tanzu-cli
that referenced
this pull request
Mar 28, 2024
Signed-off-by: Marc Khouzam <marc.khouzam@broadcom.com>
vuil
pushed a commit
that referenced
this pull request
Mar 28, 2024
Signed-off-by: Marc Khouzam <marc.khouzam@broadcom.com>
marckhouzam
added
the
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This is a small cleanup PR which removes some code duplication and fixes some invalid comments.
There is no functionality change.
Which issue(s) this PR fixes
Fixes # N/A
Describe testing done for PR
Let CI run
Release note
Additional information
Special notes for your reviewer