-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the tanzu login command to log in to TAP SaaS #715
Conversation
bb85746
to
2bc4c29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @prkalle ! I'm going to start using tanzu login
instead of tanzu context create
now 😄
Could you add some release notes in the PR description?
All my comments are nits.
I didn't approve simply because the PR needs to use projectID now that #711 has been merged. |
676e68f
to
17dbd75
Compare
ed8d4c7
to
fa7880b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM
Could you just remove the TODO section from the PR description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes and updates!
lgtm, just a nit on the markdown.
fa7880b
to
b759e48
Compare
- Refactor/update the existing deprecated tanzu login command to login to TAP SaaS Signed-off-by: Prem Kumar Kalle <prem.kalle@broadcom.com> Update the docs for tanzu login command Signed-off-by: Prem Kumar Kalle <prem.kalle@broadcom.com>
b759e48
to
0f1da9c
Compare
What this PR does / why we need it
This PR update the tanzu login command to log in to TAP SaaS platform
Changes Summary:
tanzu context
command to manage(delete/use) the context.Which issue(s) this PR fixes
Fixes #
Login to production using
tanzu login
and was able to create a context. Also thetanzu project list
andtanzu project use
andtanzu space list
working as expected.With the current active resource of tanzu context set to
project
, did a re-login to verify the users current context is handled gracefully. The login was successful and the kubeconfig(pointing to the project resource) and context active resources are set in tact.Removed the kube context related to the tanzu context from the kubeconfig file and did re-login. The login was success and kubeconfig is generated again.
tanzu context was set to space and did re-login. The login was successful and the context active resource was kept in tact( honoured the users existing context setting).
Logged in to staging env. It was successful and the context name was appended with
-staging
and hash string of the endpoint.Describe testing done for PR
Release note
Additional information
Special notes for your reviewer