-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for individual plugin download with tanzu plugin download-bundle
command
#725
Add support for individual plugin download with tanzu plugin download-bundle
command
#725
Conversation
8ae4e6f
to
b9a1fb4
Compare
…d-bundle` command
b9a1fb4
to
cc1c913
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This is something we really need!
Some minor comments to discuss.
I just noticed that when the
|
- Docs update. - Only download latest version when version is not specified - Throw an error when no plugins found/incorrect pluginID specified - Add log message to include the plugins - Shell completion for `--plugin` flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the short form of the target does not seems to work:
$ tz plugin download-bundle --image localhost:9876/tanzu-cli/plugins/central:small --dry-run --plugin cluster@k8s
[!] Skipping the plugins discovery image signature verification for "localhost:9876/tanzu-cli/plugins/central:small"
[i] Getting selected plugin information...
[i] will be downloading the one plugin from group: vmware-tanzucli/essentials:v9.9.9
[x] : error while getting selected plugin and plugin group information: no plugins found for pluginID "cluster@k8s"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for spending the time to do the shell completion.
It can be pretty complicated but I believe it makes the use of the new flag much easier for users!
I'll be honest that I'm not loving the fact that we always complete the target automatically. I would have liked that we only complete the target if needed, but with fuzzy matching it may not be easy. I'm just mentioning it but I feel it is ok to leave it as you have it for now.
6e32544
to
301711f
Compare
301711f
to
ee17825
Compare
a8eeec3
to
a784120
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it!
…d-bundle` command (vmware-tanzu#725) * Add support for individual plugin download with `tanzu plugin download-bundle` command
…d-bundle` command (#725) * Add support for individual plugin download with `tanzu plugin download-bundle` command
What this PR does / why we need it
Add support for individual plugin download with
tanzu plugin download-bundle
command and Add E2E testsThis PR adds a new flag
--plugin
as part oftanzu plugin download-bundle
command which takes pluginID as value.Based on the specified pluginID, matching plugins will be downloaded as a bundle that can be transferred and uploaded to the airgapped repository. Please see documentation update on how to use
--plugin
flag.Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer