Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow turning off go's buildvcs #743

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

marckhouzam
Copy link
Contributor

What this PR does / why we need it

There are situations where people want to build the CLI without having git present. This requires turning off buildvcs in the go build command.

This PR allows to turn off buildvcs by setting the BUILDVCS=false environment variable.

Which issue(s) this PR fixes

Fixes N/A

Describe testing done for PR

# By default -buildvcs=true
$ make prepare-builder
cd cmd/plugin/builder && go build -buildvcs=true -o /Users/kmarc/git/tanzu-cli/bin/builder .

# can override -buildvcs=false
$ BUILDVCS=false make prepare-builder
cd cmd/plugin/builder && go build -buildvcs=false -o /Users/kmarc/git/tanzu-cli/bin/builder .

Release note

Allow turning off go's `buildvcs` when building the CLI.

Additional information

Special notes for your reviewer

Signed-off-by: Marc Khouzam <marc.khouzam@broadcom.com>
@marckhouzam marckhouzam requested a review from a team as a code owner April 20, 2024 02:23
Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@marckhouzam marckhouzam merged commit 397ea59 into vmware-tanzu:main Apr 20, 2024
8 checks passed
@marckhouzam marckhouzam deleted the fix/nobuildvcs branch April 20, 2024 03:00
@marckhouzam marckhouzam added this to the v1.3.0 milestone Apr 20, 2024
vuil pushed a commit to vuil/tanzu-cli that referenced this pull request May 1, 2024
Signed-off-by: Marc Khouzam <marc.khouzam@broadcom.com>
vuil pushed a commit that referenced this pull request May 1, 2024
Signed-off-by: Marc Khouzam <marc.khouzam@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants