This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Fix docker cache invalidation due to missing build argument #4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@vmware.com>
3 tasks
yharish991
approved these changes
Mar 8, 2023
avi-08
pushed a commit
to avi-08/tanzu-framework
that referenced
this pull request
Mar 10, 2023
…anzu#4462) Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@vmware.com>
rajathagasthya
pushed a commit
to rajathagasthya/tanzu-framework
that referenced
this pull request
Apr 26, 2023
…anzu#4462) Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@vmware.com>
rajathagasthya
pushed a commit
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@vmware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The build-tooling.mk has
testtarget defined as follows:In the second docker build, the build argument is not passed for configuring the go proxy. This argument is passed in all other relevant docker builds. As a result, the docker cache got computed again and added some time to the overall build.
With this fix, the cache does not get re-computed.
Which issue(s) this PR fixes
Fixes #4465
Describe testing done for PR
Testing is done locally by clearing the docker cache and ensuring the go mod cache is populated only once for each component.
Release note
Additional information
Special notes for your reviewer