Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Add Tanzu Hub Mock Server for Unit Testing #191

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented May 29, 2024

What this PR does / why we need it

  • This PR adds a hub/testing package that allows plugin authors to easily write unit tests using a mock GraphQL server endpoint for plugins that interact with the Tanzu Hub endpoint.

Note: This feature is EXPERIMENTAL. The API signature and implementation are subject to change or removal if an alternative means of providing equivalent functionality is introduced.

More details about how to use this package for writing unit tests can be found client/hub/testing/README.md

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

[Experimental] Add Tanzu Hub Mock Server for Unit Testing

Additional information

Special notes for your reviewer

@anujc25 anujc25 force-pushed the add-hub-mock-server-for-testing branch 2 times, most recently from 9c2938a to d66b81a Compare May 29, 2024 18:01
@anujc25 anujc25 marked this pull request as ready for review May 30, 2024 18:55
@anujc25 anujc25 requested a review from a team as a code owner May 30, 2024 18:55
@anujc25 anujc25 force-pushed the add-hub-mock-server-for-testing branch from 6a114e8 to a4a7cf0 Compare May 30, 2024 20:34
@anujc25 anujc25 force-pushed the add-hub-mock-server-for-testing branch 4 times, most recently from 74f398d to 6b2854b Compare June 20, 2024 21:08
@anujc25 anujc25 force-pushed the add-hub-mock-server-for-testing branch from 6b2854b to 5615772 Compare June 20, 2024 21:11
vuil
vuil previously approved these changes Jun 20, 2024
Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

nit: Since client/hub/README.md is currently the main file one would read to undestand how to use the hub client. How about add a line in that file to reference the readme in the testing package?

Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for the update.

@anujc25 anujc25 merged commit daea713 into vmware-tanzu:main Jun 28, 2024
4 checks passed
@marckhouzam marckhouzam added this to the v1.4.0 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants