Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Colors as part of the OutputWriter's Table output's field #194

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented Jun 13, 2024

What this PR does / why we need it

Support Colors as part of the OutputWriter's Table output's field.

Before this change, when multiple words needed to be colored, the text was wrapped into a new line.

  • Use the tablewriter library that contains the fix to support CSI colors
  • Switch to github.com/anujc25/tablewriter from github.com/olekukonko/tablewriter

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

  • Added a unit test.
  • Manually verified.

Release note

Support Colors as part of the OutputWriter's Table output's field

Additional information

Special notes for your reviewer

@anujc25 anujc25 requested a review from a team as a code owner June 13, 2024 18:37
Switch to github.com/anujc25/tablewriter from github.com/olekukonko/tablewriter
@marckhouzam marckhouzam added this to the v1.4.0 milestone Jun 13, 2024
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Nice fix for a tricky situation.

Copy link
Contributor

@prkalle prkalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes!

@anujc25 anujc25 merged commit 45c9987 into main Jun 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants