Update golangci-lint to 1.52.2 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the updated linters require go 1.19 so this commit updates the github workflow to use go 1.19 for the "check" section. Note that "allow-leading-space" is no longer supported as mentioned in golangci/golangci-lint#3063 (comment) Fix new warnings that are now reported. Signed-off-by: Marc Khouzam <kmarc@vmware.com>
marckhouzam
force-pushed
the
feat/updateGolangci
branch
from
2b9aa88
to
f682ea2
Compare
mpanchajanya
approved these changes
Apr 18, 2023
anujc25
approved these changes
Apr 18, 2023
vuil
pushed a commit
that referenced
this pull request
May 2, 2023
Some of the updated linters require go 1.19 so this commit updates the github workflow to use go 1.19 for the "check" section. Note that "allow-leading-space" is no longer supported as mentioned in golangci/golangci-lint#3063 (comment) Fix new warnings that are now reported. Signed-off-by: Marc Khouzam <kmarc@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rm -rf hack/tools/bin/golangci-lintWhat this PR does / why we need it
I wanted to use generics in #55 but the golangci-lint version we are using is too old and gocritic panics.
This commit updates the version to 1.52.2.
Note that "allow-leading-space" is no longer supported as mentioned in golangci/golangci-lint#3063 (comment) and therefore has been removed. All instances of
// nolinthave been update to remove the space.A couple of new warnings were also fixed.
Finally, I have rebase #55 and confirmed we can use generics without linter warnings when using this PR.
Which issue(s) this PR fixes
Fixes # N/A
Describe testing done for PR
make go-lint
I also tried #55 which is introducing generics and ran
make go-lint. Before this PR, the linter panics but with this PR it all passes.Release note
Additional information
Special notes for your reviewer