Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration APIs for Certificate configuration #62

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Add configuration APIs for Certificate configuration #62

merged 1 commit into from
Apr 26, 2023

Conversation

prkalle
Copy link
Contributor

@prkalle prkalle commented Apr 25, 2023

What this PR does / why we need it

This PR is to add configuration APIs for custom certificate configuration

The sample configuration is shown below which would be added to the configuration file (config-ng.yaml)

certs:
    - hostName: localhost:9876
      skipCertVerify: "true"
      insecure: "true"
      caCertData: <REDACTED>

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Unit tests and CI passed

Release note

Add configuration APIs for Certificate configuration

Additional information

Special notes for your reviewer

@prkalle prkalle requested a review from a team as a code owner April 25, 2023 17:56
mpanchajanya
mpanchajanya requested changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@mpanchajanya mpanchajanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!. nit! on validating the input args and negative test cases

@prkalle prkalle force-pushed the feature/custom-cert-support branch from 38a8e4e to ad351b9 Compare April 26, 2023 19:30
@prkalle
Add configuration APIs for Certificate configuration
251ae02 
Signed-off-by: Prem Kumar Kalle <pkalle@vmware.com>
@prkalle prkalle force-pushed the feature/custom-cert-support branch from ad351b9 to 251ae02 Compare April 26, 2023 21:09
@prkalle prkalle merged commit 20c441a into vmware-tanzu:main Apr 26, 2023
4 checks passed
@marckhouzam marckhouzam added this to the v0.90.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpanchajanya mpanchajanya mpanchajanya approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prkalle @mpanchajanya @marckhouzam @vmwclabot