Skip to content

Commit

Permalink
fix vsc backup plugin progress method to not fail on temporary errors
Browse files Browse the repository at this point in the history
  • Loading branch information
shubham-pampattiwar committed Jan 25, 2024
1 parent 763d3dc commit 0743c4c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions internal/backup/volumesnapshotcontent_action.go
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,11 @@ func (p *VolumeSnapshotContentBackupItemAction) Progress(operationID string, bac
if boolptr.IsSetToTrue(vsc.Status.ReadyToUse) {
progress.Completed = true
} else if vsc.Status.Error != nil {
progress.Completed = true
errorMessage := ""
if vsc.Status.Error.Message != nil {
progress.Err = *vsc.Status.Error.Message
errorMessage = *vsc.Status.Error.Message
}
p.Log.Warnf("VolumeSnapshotContent has a temporary error %s. SnapshotContent controller will retry later.", errorMessage)
}

return progress, nil
Expand Down

0 comments on commit 0743c4c

Please sign in to comment.