Add support setting Storage Account Key via configuration #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Odstrcilik <martin.odstrcilik@gmail.com>
jaygridley
force-pushed
the
storage-account-keys
branch
from
e9448ae
to
64164da
Compare
skriss
previously approved these changes
Mar 23, 2020
There was a problem hiding this comment.
thanks for the updates @jaygridley, LGTM! @carlisia @nrb @ashish-amarnath PTAL.
|
@jaygridley Is this ready to be merged? |
Yes, another required approval pending. |
|
@carlisia @nrb @ashish-amarnath - gentle reminder to please review this PR! |
carlisia
previously approved these changes
Mar 30, 2020
Signed-off-by: Martin Odstrcilik <martin.odstrcilik@gmail.com>
skriss
approved these changes
Mar 30, 2020
|
thanks again @jaygridley!! |
dymurray
added a commit
to dymurray/velero-plugin-for-microsoft-azure
that referenced
this pull request
Oct 17, 2023
Bug 2189173 - upgrade golang.org/x/net to 0.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #10