Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore log needs more clarity when object already exists and isn't different #1142

Closed
ncdc opened this issue Jan 4, 2019 · 1 comment
Closed
Labels
Enhancement/User End-User Enhancement to Velero Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! Help wanted

Comments

@ncdc
Copy link
Contributor

ncdc commented Jan 4, 2019

While debugging #1138, what I discovered is the following sequence of events:

  1. Ark tries to restore a PV
  2. It gets an already-exists error
  3. There are no differences between fromBackup and fromCluster
  4. Therefore it's a no-op

The only relevant/related log line for the above is

time="2019-01-03T14:36:29Z" level=info msg="Restoring PersistentVolume: pvc-18ceea3e-0a8d-11e9-aef1-02f9e6d3ca22" backup=pont logSource="pkg/restore/restore.go:796" restore=heptio-ark/pont-20190103153555

The restore has no warnings or errors.

I think we should consider changing the log line from Restoring <type>: <name> ... to Attempting to restore <type>: ...

I also think we should consider adding a log line to the effect Did not restore <type>: <name> because it already exists and is identical to the backed up copy

@ncdc ncdc added Help wanted Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! Enhancement/User End-User Enhancement to Velero labels Jan 4, 2019
@ncdc
Copy link
Contributor Author

ncdc commented Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement/User End-User Enhancement to Velero Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! Help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant