Restore Log Entry Clarification #1152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruben Orduz <orduzr@vmware.com>
skriss
reviewed
Jan 9, 2019
| @@ -848,6 +848,7 @@ func (ctx *context) restoreResource(resource, namespace, resourcePath string) (a | |||
| addToResult(&warnings, namespace, e) | |||
| } | |||
| } | |||
| ctx.log.Infof("Unable to restore %s: %v because it already exists and is identical to the backed up copy", obj.GroupVersionKind().Kind, name) | |||
There was a problem hiding this comment.
I think this needs to go into an else block, right? Otherwise, there are a couple of cases from the "not equal" if block above that will fall through and hit this, which will be incorrect. If I'm reading it correctly the continue should remain outside the else since we want to continue for any case where we hit an AlreadyExists error.
There was a problem hiding this comment.
Which of 3 if statements would it be more pertinent to attach the else clause to? You think it might be worth refactoring by joining the 3 ifseses by else if and then finally else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1142
Feel free to close if you want to wait for an outsider newbie who wants to take it.