Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use GA toplogy labels for PVs #2173

Closed
skriss opened this issue Jan 6, 2020 · 2 comments · Fixed by #2219
Closed

update to use GA toplogy labels for PVs #2173

skriss opened this issue Jan 6, 2020 · 2 comments · Fixed by #2219
Assignees
Labels
Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! Help wanted kind/tech-debt

Comments

@skriss
Copy link
Member

skriss commented Jan 6, 2020

As of Kubernetes 1.17, the labels that capture a PV's region & zone have gone GA:

Velero currently uses the older beta version of the zone label in at least one place that I'm aware of:

We probably want to use the GA version of the label, if it exists, otherwise fall back to the beta version. At some point we'll be able to drop support entirely for the beta version of the label -- we can add a TODO to the code for this.

@skriss skriss added Help wanted P2 - Long-term important kind/tech-debt Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! labels Jan 6, 2020
@cpanato
Copy link
Contributor

cpanato commented Jan 16, 2020

@skriss can i take this to try out?

@skriss
Copy link
Member Author

skriss commented Jan 17, 2020

yes, absolutely! Let me know if you need any further input beyond what I put in the initial description. The main thing to think about here is making sure we remain backwards-compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! Help wanted kind/tech-debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants