use GA topology labels for PVs #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
carlisia
reviewed
Jan 27, 2020
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
skriss
suggested changes
Jan 30, 2020
There was a problem hiding this comment.
sorry for the delay in reviewing here @cpanato. Added a couple specific comments.
I'd also like to add a unit test case or two for this. We already have a test case here around the existing AZ label:
https://github.com/vmware-tanzu/velero/blob/master/pkg/backup/backup_test.go#L1743-L1776
It'd be nice to:
- add a test case that confirms that if both labels exist on the PV, the GA one is the one that's used
- add a test case that confirms that if only the GA label exists on the PV, it's used
- perhaps just re-title the existing test case to something like "if only the beta label exists on the PV, it's used"
Let me know if you have any questions on the structure of the test; hopefully a copy-paste with some modifications works.
Thanks again for the PR!
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
|
@skriss thanks so much for taking your time to review. |
skriss
approved these changes
Feb 3, 2020
|
@carlisia please take another look when you get a chance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add stable topology labels for PV the old label was deprecated in K8s 1.17 - https://kubernetes.io/docs/reference/kubernetes-api/labels-annotations-taints/#topologykubernetesiozone