Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3rd party controller to build an automatic way to backup all volume resources in the cluster #2375

Closed
duyanghao opened this issue Mar 30, 2020 · 7 comments · Fixed by #2393

Comments

@duyanghao
Copy link
Contributor

duyanghao commented Mar 30, 2020

Describe the problem/challenge you have
Refers to #2355

Is there a do-one-command or automatic way for us to backup all persistent volume resources in the cluster? Right now, we have to add relevant annotations to all of pods with pv resources in cluster, which is complicated and unpractical in a production environment.

Velero doesn't have a built-in command to do this, you'd need to write your own script/automation. You could check out this community project: https://github.com/bitsbeats/velero-pvc-watcher

Describe the solution you'd like
Build an automatic way to backup all volume resources in the cluster

Anything else you would like to add:
@skriss To solve this, I have created a repo called velero-volume-controller, which is a Kubernetes controller for velero that detects and adds relevant backup annotation to pods with volumes. Could you take a look at this and add it to the 3rd party controller part in the velero Restic Integration docs?

velero-volume-controller

@carlisia
Copy link
Contributor

I added this topic to our community meeting tomorrow (3/31): https://hackmd.io/Jq6F5zqZR7S80CeDWUklkA?both#March-31-2020.

@nrb
Copy link
Contributor

nrb commented Apr 1, 2020

@duyanghao Do you to continue supporting this controller? Is it commercially backed?

@duyanghao
Copy link
Contributor Author

duyanghao commented Apr 1, 2020

@nrb

Do you to continue supporting this controller?

Yes

Is it commercially backed?

Not yet, but currently, our team plans to use this controller combined with velero Restic Integration to backup and restore Kubernetes clusters in a production environment.

@skriss
Copy link
Member

skriss commented Apr 2, 2020

FYI we already have https://github.com/vmware-tanzu/velero/blob/master/site/docs/master/restic.md#3rd-party-controller in our docs. I don't see any issue with linking to third-party community projects, we should just be clear about ownership.

@skriss
Copy link
Member

skriss commented Apr 2, 2020

btw, this looks like a neat project @duyanghao!

@duyanghao
Copy link
Contributor Author

duyanghao commented Apr 3, 2020

FYI we already have https://github.com/vmware-tanzu/velero/blob/master/site/docs/master/restic.md#3rd-party-controller in our docs. I don't see any issue with linking to third-party community projects, we should just be clear about ownership.

@skriss I guess you mistake my meaning of add it to the 3rd party controller part. What I want to say is that maybe velero official can add velero-volume-controller to the list of velero restic 3rd party controller as an implemented
choice since the recommended controller(i.e. velero-pvc-watcher) can't satisfy the demand of building an automatic way to backup all volume resources in the cluster.

I have create a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants