Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the velero snapshot-location command #2426

Open
carlisia opened this issue Apr 13, 2020 · 0 comments
Open

Improve the velero snapshot-location command #2426

carlisia opened this issue Apr 13, 2020 · 0 comments
Assignees
@reasonerjt
Labels
Area/CLI related to the command-line interface Enhancement/User End-User Enhancement to Velero kind/requirement Reviewed Q2 2021
Milestone
Prioritized issues

Comments

@carlisia
Copy link
Contributor

carlisia commented Apr 13, 2020 •
edited

Add these flags:

set
        --default mapStringString         sets the list of unique volume providers and default volume snapshot location (provider1:location-01,provider2:location-02,...) (NEW, -- was `server --default-volume-snapshot-locations; could be set as an annotation on the VSL)  
        --credentials mapStringString     sets the list of name of the corresponding credentials secret for providers. Format is (provider1:credentials-secret-name1,provider2:credentials-secret-name2,...) (NEW)

create                                    NAME [flags]
        --default                         Sets these new locations to be the new default snapshot locations. Default is false. (NEW)
        --credentials mapStringString     sets the list of name of the corresponding credentials secret for providers. Format is (provider1:credentials-secret-name1,provider2:credentials-secret-name2,...) (NEW)
@carlisia carlisia added Enhancement/User End-User Enhancement to Velero Area/CLI related to the command-line interface labels Apr 13, 2020
@carlisia carlisia self-assigned this Apr 13, 2020
@skriss skriss added this to the v1.5 milestone May 28, 2020
@carlisia carlisia mentioned this issue Jul 28, 2020
Open
12 tasks
@stephbman stephbman modified the milestones: v1.5, v1.6 Aug 11, 2020
@carlisia carlisia removed their assignment Oct 21, 2020
@nrb nrb added this to To do in v1.6.0 Nov 2, 2020
@carlisia carlisia moved this from To do to In progress in v1.6.0 Dec 16, 2020
@nrb nrb modified the milestones: v1.6.0, v1.7.0 Feb 22, 2021
@nrb nrb added this to To do in v1.7.0 via automation Feb 22, 2021
@nrb nrb removed this from To do in v1.7.0 Feb 22, 2021
@nrb nrb removed this from In progress in v1.6.0 Feb 22, 2021
@nrb nrb added this to To do in v1.7.0 via automation Feb 22, 2021
zubron added a commit to zubron/velero that referenced this issue Mar 11, 2021
@zubron
Partially revert adding credentials to VSL
24dbc20 
We are no longer adding the Credentials field to the VSL so this reverts
part the change that added it (vmware-tanzu#3409).

The original PR also added the `snapshot-location set` command. This
command only included options for setting the credential but is part of
the work for vmware-tanzu#2426. Due to this, the command has been left in place
(with the credentials option removed) but has been hidden.

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
@zubron zubron mentioned this issue Mar 11, 2021
Merged
3 tasks
zubron added a commit to zubron/velero that referenced this issue Mar 11, 2021
@zubron
Partially revert adding credentials to VSL
ea3f6fe 
We are no longer adding the Credentials field to the VSL so this reverts
part the change that added it (vmware-tanzu#3409).

The original PR also added the `snapshot-location set` command. This
command only included options for setting the credential but is part of
the work for vmware-tanzu#2426. Due to this, the command has been left in place
(with the credentials option removed) but has been hidden.

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
ashish-amarnath pushed a commit that referenced this issue Mar 11, 2021
@zubron
Partially revert adding credentials to VSL (#3561)
3656f45 
We are no longer adding the Credentials field to the VSL so this reverts
part the change that added it (#3409).

The original PR also added the `snapshot-location set` command. This
command only included options for setting the credential but is part of
the work for #2426. Due to this, the command has been left in place
(with the credentials option removed) but has been hidden.

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
@dsu-igeek dsu-igeek added this to To do in Velero 1.7.0 via automation Apr 21, 2021
@dsu-igeek dsu-igeek removed this from To do in v1.7.0 Apr 21, 2021
dharmab pushed a commit to dharmab/velero that referenced this issue May 25, 2021
@zubron @dharmab
Partially revert adding credentials to VSL (vmware-tanzu#3561)
535c359 
We are no longer adding the Credentials field to the VSL so this reverts
part the change that added it (vmware-tanzu#3409).

The original PR also added the `snapshot-location set` command. This
command only included options for setting the credential but is part of
the work for vmware-tanzu#2426. Due to this, the command has been left in place
(with the credentials option removed) but has been hidden.

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
ywk253100 pushed a commit to ywk253100/velero that referenced this issue Jun 29, 2021
@zubron @ywk253100
Partially revert adding credentials to VSL (vmware-tanzu#3561)
606f11c 
We are no longer adding the Credentials field to the VSL so this reverts
part the change that added it (vmware-tanzu#3409).

The original PR also added the `snapshot-location set` command. This
command only included options for setting the credential but is part of
the work for vmware-tanzu#2426. Due to this, the command has been left in place
(with the credentials option removed) but has been hidden.

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
@zubron zubron modified the milestones: v1.7.0, v1.8.0 Jul 30, 2021
@zubron zubron removed this from To do in Velero 1.7.0 Jul 30, 2021
@dsu-igeek dsu-igeek added this to To Do in v1.8.0 Oct 20, 2021
@ywk253100 ywk253100 mentioned this issue Dec 6, 2021
Closed
@reasonerjt reasonerjt mentioned this issue Jan 10, 2022
Open
@reasonerjt reasonerjt assigned reasonerjt and unassigned zubron Jan 28, 2022
@eleanor-millman eleanor-millman removed this from To Do in v1.8.0 Feb 22, 2022
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this issue May 14, 2022
@zubron @gyaozhou
Partially revert adding credentials to VSL (vmware-tanzu#3561)
a88e5b0 
We are no longer adding the Credentials field to the VSL so this reverts
part the change that added it (vmware-tanzu#3409).

The original PR also added the `snapshot-location set` command. This
command only included options for setting the credential but is part of
the work for vmware-tanzu#2426. Due to this, the command has been left in place
(with the credentials option removed) but has been hidden.

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reasonerjt reasonerjt

Labels
Area/CLI related to the command-line interface Enhancement/User End-User Enhancement to Velero kind/requirement Reviewed Q2 2021
Projects
None yet
Milestone
Prioritized issues
Development

No branches or pull requests
7 participants
@carlisia @nrb @reasonerjt @skriss @zubron @eleanor-millman @stephbman