Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the "Basic" test case to cover more resources when doing the backup/restore #4099

Closed
ywk253100 opened this issue Sep 2, 2021 · 2 comments · Fixed by #4455
Closed
Assignees
Labels
E2E Tests End to end test
Projects

Comments

@ywk253100
Copy link
Contributor

We run the Basic test case on PR's checking but the Basic test case only covers the backup/restore of namespaces, this isn't enough to find the potential bugs introduced by the PR, #4098 is a good example.

So we need to expand the Basic test case to cover more resources:

  1. Run the backup/restore with the kibishii but don't backup volumes(the kind doesn't support backup volumes via both restic or snapshot)
  2. Consider the changes in adding RBAC test to e2e tests #3982 and adding namespace annotation test to e2e tests #3944

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@ywk253100 ywk253100 added the E2E Tests End to end test label Sep 2, 2021
@reasonerjt
Copy link
Contributor

If we need to make a choice between 1 and 2, I'd vote 2 b/c the scenario in 1 has been covered in other cases.

@stale
Copy link

stale bot commented Nov 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the staled label Nov 1, 2021
@danfengliu danfengliu added this to To Do in v1.8.0 via automation Nov 8, 2021
@danfengliu danfengliu added this to the v1.8.0 milestone Nov 8, 2021
@stale stale bot removed the staled label Nov 8, 2021
@danfengliu danfengliu assigned qiuming-best and unassigned danfengliu Dec 6, 2021
@danfengliu danfengliu linked a pull request Jan 10, 2022 that will close this issue
3 tasks
v1.8.0 automation moved this from To Do to Done Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Tests End to end test
Projects
Development

Successfully merging a pull request may close this issue.

5 participants