Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot restore "service" with velero build from the main branch #4098

Closed
ywk253100 opened this issue Sep 2, 2021 · 1 comment · Fixed by #4101
Closed

Cannot restore "service" with velero build from the main branch #4098

ywk253100 opened this issue Sep 2, 2021 · 1 comment · Fixed by #4101
Assignees
Labels
Bug kind/release-blocker Must fix issues for the coming release (milestone)
Milestone

Comments

@ywk253100
Copy link
Contributor

Run restore with velero built from the main branch, get the following errors:

error restoring services/kibishii-workload/etcd-client: Service "etcd-client" is invalid: spec.clusterIPs: Invalid value: []string{"100.70.53.8"}: must be empty when clusterIP is empty
error restoring services/kibishii-workload/etcd0: Service "etcd0" is invalid: spec.clusterIPs: Invalid value: []string{"100.66.73.184"}: must be empty when clusterIP is empty
error restoring services/kibishii-workload/etcd1: Service "etcd1" is invalid: spec.clusterIPs: Invalid value: []string{"100.69.23.44"}: must be empty when clusterIP is empty
error restoring services/kibishii-workload/etcd2: Service "etcd2" is invalid: spec.clusterIPs: Invalid value: []string{"100.64.23.70"}: must be empty when clusterIP is empty

This is caused by that we bumped up the version of library k8s.io/api/core/v1 from v0.19.12 to v0.20.9 in PR #4022.
There is a new property ClusterIPs introduced in v0.20.9 https://github.com/kubernetes/api/blob/v0.20.9/core/v1/types.go#L4098 and the restore action empties the ClusterIP but not for ClusterIPs https://github.com/vmware-tanzu/velero/blob/main/pkg/restore/service_action.go#L56

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@ywk253100 ywk253100 added Bug kind/release-blocker Must fix issues for the coming release (milestone) labels Sep 2, 2021
@ywk253100 ywk253100 added this to the v1.7.0 milestone Sep 2, 2021
@ywk253100 ywk253100 self-assigned this Sep 2, 2021
@ywk253100 ywk253100 added this to To do in Velero 1.7.0 via automation Sep 2, 2021
ywk253100 added a commit to ywk253100/velero that referenced this issue Sep 2, 2021
…"None"

More details please refer to vmware-tanzu#4098

Fixes vmware-tanzu#4098

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100 added a commit to ywk253100/velero that referenced this issue Sep 2, 2021
…"None"

More details please refer to vmware-tanzu#4098

Fixes vmware-tanzu#4098

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
@kycfeel
Copy link

kycfeel commented Sep 3, 2021

I also noticed this issue too. The services cannot be restored due to:

error restoring services/<MY_NAMESPACE>/<MY_SERVICE>: Service "<MY_SERVICE>" is invalid: spec.clusterIPs: Invalid value: []string{"<MY_CNI_IP>"}: must be empty when clusterIP is empty

this error.

Velero 1.7.0 automation moved this from To do to Done Sep 3, 2021
zubron pushed a commit that referenced this issue Sep 3, 2021
…"None" (#4101)

More details please refer to #4098

Fixes #4098

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
sseago pushed a commit to sseago/velero that referenced this issue Sep 3, 2021
…terIP" isn't "None" (vmware-tanzu#4101)

(cherry-pick from upstream)
More details please refer to vmware-tanzu#4098

Fixes vmware-tanzu#4098

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
sseago pushed a commit to sseago/velero that referenced this issue Sep 3, 2021
…ware-tanzu#4101)

(cherry-pick from upstream)
More details please refer to vmware-tanzu#4098

Fixes vmware-tanzu#4098

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
sseago pushed a commit to sseago/velero that referenced this issue Sep 3, 2021
…-tanzu#4101)

(cherry-pick from upstream)
More details please refer to vmware-tanzu#4098

Fixes vmware-tanzu#4098

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
danfengliu pushed a commit to danfengliu/velero that referenced this issue Jan 25, 2022
…"None" (vmware-tanzu#4101)

More details please refer to vmware-tanzu#4098

Fixes vmware-tanzu#4098

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this issue May 14, 2022
…"None" (vmware-tanzu#4101)

More details please refer to vmware-tanzu#4098

Fixes vmware-tanzu#4098

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug kind/release-blocker Must fix issues for the coming release (milestone)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants