You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the problem/challenge you have
In PR #4341, a new logger is introduced to controller manager. Any reconciler error will be recorded by it, so existing error logs in reconciler function before returning are duplicated.
Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Remove the existing error logs in reconciler function before returning.
Format the returning error message to include removed error log's information.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
This is a log enhancement. No function change is supposed.
Environment:
Velero version (use velero version): v1.7.0
Kubernetes version (use kubectl version): v1.21
Kubernetes installer & version: kind
Cloud provider or hardware configuration: none
OS (e.g. from /etc/os-release): MacOS
Vote on this issue!
This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.
👍 for "The project would be better with this feature added"
👎 for "This feature will not enhance the project in a meaningful way"
The text was updated successfully, but these errors were encountered:
Remove duplicated log entries, which are introduced by logger added in controller manager in pull request vmware-tanzu#4341.
fix issue vmware-tanzu#4368
Signed-off-by: Xun Jiang <jxun@vmware.com>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Describe the problem/challenge you have
In PR #4341, a new logger is introduced to controller manager. Any reconciler error will be recorded by it, so existing error logs in reconciler function before returning are duplicated.
Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
This is a log enhancement. No function change is supposed.
Environment:
velero version
): v1.7.0kubectl version
): v1.21/etc/os-release
): MacOSVote on this issue!
This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.
The text was updated successfully, but these errors were encountered: