Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated logs after adding logger in controller manager #4368

Closed
blackpiglet opened this issue Nov 18, 2021 · 1 comment
Closed
Assignees
Labels
Enhancement/Dev Internal or Developer-focused Enhancement to Velero staled

Comments

@blackpiglet
Copy link
Contributor

Describe the problem/challenge you have
In PR #4341, a new logger is introduced to controller manager. Any reconciler error will be recorded by it, so existing error logs in reconciler function before returning are duplicated.

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

  1. Remove the existing error logs in reconciler function before returning.
  2. Format the returning error message to include removed error log's information.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
This is a log enhancement. No function change is supposed.

Environment:

  • Velero version (use velero version): v1.7.0
  • Kubernetes version (use kubectl version): v1.21
  • Kubernetes installer & version: kind
  • Cloud provider or hardware configuration: none
  • OS (e.g. from /etc/os-release): MacOS

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@blackpiglet blackpiglet added the Enhancement/Dev Internal or Developer-focused Enhancement to Velero label Nov 18, 2021
@blackpiglet blackpiglet self-assigned this Nov 18, 2021
@blackpiglet blackpiglet added this to To Do in v1.8.0 via automation Nov 18, 2021
@blackpiglet blackpiglet moved this from To Do to In Progress in v1.8.0 Nov 18, 2021
@blackpiglet blackpiglet moved this from In Progress to To Do in v1.8.0 Nov 18, 2021
@reasonerjt reasonerjt added this to the v1.8.0 milestone Nov 18, 2021
@blackpiglet blackpiglet added this to To do in Velero v1.8 Sprint 7 (12-Jan-2022) via automation Nov 18, 2021
@blackpiglet blackpiglet moved this from To do to In progress in Velero v1.8 Sprint 7 (12-Jan-2022) Nov 18, 2021
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Nov 22, 2021
Remove duplicated log entries, which are introduced by logger added in controller manager in pull request vmware-tanzu#4341.
fix issue vmware-tanzu#4368

Signed-off-by: Xun Jiang <jxun@vmware.com>
@blackpiglet blackpiglet removed this from the v1.8.0 milestone Dec 20, 2021
@stale
Copy link

stale bot commented Feb 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the staled label Feb 18, 2022
@eleanor-millman eleanor-millman removed this from To Do in v1.8.0 Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement/Dev Internal or Developer-focused Enhancement to Velero staled
Projects
None yet
Development

No branches or pull requests

2 participants