Add default values for defaultItemOperationTimeout and itemOperationSyncFrequency in velero CLI #6298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-pampattiwar
force-pushed
the
add-default-values
branch
from
d26a9f1
to
3e00550
Compare
sseago
reviewed
May 22, 2023
…yncFrequency in velero CLI Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> add changelog Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> update default value for itemOperationsSyncFrequency Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
shubham-pampattiwar
force-pushed
the
add-default-values
branch
from
3e00550
to
2aaa85b
Compare
sseago
approved these changes
Jun 8, 2023
Lyndon-Li
reviewed
Jun 13, 2023
| command.Flags().BoolVar(&config.defaultVolumesToFsBackup, "default-volumes-to-fs-backup", config.defaultVolumesToFsBackup, "Backup all volumes with pod volume file system backup by default.") | ||
| command.Flags().StringVar(&config.uploaderType, "uploader-type", config.uploaderType, "Type of uploader to handle the transfer of data of pod volumes") | ||
| command.Flags().DurationVar(&config.defaultItemOperationTimeout, "default-item-operation-timeout", config.defaultItemOperationTimeout, "How long to wait on asynchronous BackupItemActions and RestoreItemActions to complete before timing out.") | ||
| command.Flags().DurationVar(&config.defaultItemOperationTimeout, "default-item-operation-timeout", config.defaultItemOperationTimeout, "How long to wait on asynchronous BackupItemActions and RestoreItemActions to complete before timing out. Default is 1 hour") |
There was a problem hiding this comment.
@shubham-pampattiwar
Could you change the default value for defaultItemOperationTimeout to 4 hour btw?
This value will be used by data mover, I am afraid 1 hour is not enough for large disks. Moreover, 4 hour is consistent with the current PVB timeout as well.
cc @sseago
There was a problem hiding this comment.
Sure, this makes sense. Note that this PR currently just documents the defaults. If we want to actually change them, then the const where they're defined needs to be changed too.
There was a problem hiding this comment.
Yes. Let me first approve this PR. Alternatively, we can also let this PR merged first, and change the default value later in some data mover PR.
Lyndon-Li
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
defaultItemOperationTimeoutas 1 houritemOperationSyncFrequencyas 2 minDoes your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.