-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default values for defaultItemOperationTimeout and itemOperationSyncFrequency in velero CLI #6298
Add default values for defaultItemOperationTimeout and itemOperationSyncFrequency in velero CLI #6298
Conversation
d26a9f1
to
3e00550
Compare
…yncFrequency in velero CLI Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> add changelog Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> update default value for itemOperationsSyncFrequency Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
3e00550
to
2aaa85b
Compare
command.Flags().BoolVar(&config.defaultVolumesToFsBackup, "default-volumes-to-fs-backup", config.defaultVolumesToFsBackup, "Backup all volumes with pod volume file system backup by default.") | ||
command.Flags().StringVar(&config.uploaderType, "uploader-type", config.uploaderType, "Type of uploader to handle the transfer of data of pod volumes") | ||
command.Flags().DurationVar(&config.defaultItemOperationTimeout, "default-item-operation-timeout", config.defaultItemOperationTimeout, "How long to wait on asynchronous BackupItemActions and RestoreItemActions to complete before timing out.") | ||
command.Flags().DurationVar(&config.defaultItemOperationTimeout, "default-item-operation-timeout", config.defaultItemOperationTimeout, "How long to wait on asynchronous BackupItemActions and RestoreItemActions to complete before timing out. Default is 1 hour") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubham-pampattiwar
Could you change the default value for defaultItemOperationTimeout
to 4 hour btw?
This value will be used by data mover, I am afraid 1 hour is not enough for large disks. Moreover, 4 hour is consistent with the current PVB timeout as well.
cc @sseago
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, this makes sense. Note that this PR currently just documents the defaults. If we want to actually change them, then the const where they're defined needs to be changed too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Let me first approve this PR. Alternatively, we can also let this PR merged first, and change the default value later in some data mover PR.
Thank you for contributing to Velero!
Please add a summary of your change
defaultItemOperationTimeout
as 1 houritemOperationSyncFrequency
as 2 minDoes your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.