Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Completed" pod is not restored although is was backed up #6605

Open
danfengliu opened this issue Aug 4, 2023 · 1 comment
Open

"Completed" pod is not restored although is was backed up #6605

danfengliu opened this issue Aug 4, 2023 · 1 comment
Assignees
Labels
backlog Needs investigation Needs triage We need discussion to understand problem and decide the priority

Comments

@danfengliu
Copy link
Contributor

Describe the problem/challenge you have
We had an fixed issue #6182 which fixed a wrong backup result issue, so currently non-running pods existance won't effect the backup result, and this kind of pods will be backed up, but the pod was not restored, as we can see it was skipped accroding to velero log.

velero backup describe backup-job-1 --details --insecure-skip-tls-verify

  v1/Namespace:
    - default
  v1/PersistentVolume:
    - pvc-54c9e1b6-bb21-42e8-897a-f270e337ab91
    - pvc-6189f570-9ac0-4fe2-9be6-fc0243480162
  v1/PersistentVolumeClaim:
    - default/kibishii-data-kibishii-deployment-0
    - default/kibishii-data-kibishii-deployment-1
  v1/Pod:
    - default/etcd0
    - default/etcd1
    - default/etcd2
    - default/jump-pad
    - default/kibishii-deployment-0
    - default/kibishii-deployment-1
    - default/test11-bhrhc

time="2023-08-04T07:34:58Z" level=info msg="default/test11-bhrhc is complete - skipping" logSource="pkg/restore/restore.go:1040" restore=velero/backup-job-1-20230804073455

Describe the solution you'd like

If there is no need for Job type of pod, then we can skip backing up them. or restore them.

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@danfengliu danfengliu added Needs investigation 1.13-candidate issue/pr that should be considered to target v1.13 minor release labels Aug 4, 2023
@sseago
Copy link
Collaborator

sseago commented Aug 4, 2023

Skipping backup makes more sense than restoring. If you restore a completed pod, since Status is not included in the initial Create call, the scheduler will attempt to run the pod on restore, which is not desired for a pod which has already run to completion.

@danfengliu danfengliu added this to the v1.12 milestone Aug 6, 2023
@danfengliu danfengliu removed the 1.13-candidate issue/pr that should be considered to target v1.13 minor release label Aug 7, 2023
@reasonerjt reasonerjt removed this from the v1.12 milestone Aug 9, 2023
@reasonerjt reasonerjt added backlog Needs triage We need discussion to understand problem and decide the priority labels Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Needs investigation Needs triage We need discussion to understand problem and decide the priority
Projects
None yet
Development

No branches or pull requests

4 participants