Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.10 and later - Pod volume backup keeps partial failing for namespaces with pods in completed state #6182

Closed
Lyndon-Li opened this issue Apr 25, 2023 · 3 comments
Closed

v1.10 and later - Pod volume backup keeps partial failing for namespaces with pods in completed state #6182

Lyndon-Li opened this issue Apr 25, 2023 · 3 comments
Assignees
@Lyndon-Li
Labels
area/fs-backup target/1.10.3 target/1.11.1
Milestone
v1.12

Comments

@Lyndon-Li
Copy link
Contributor

Lyndon-Li commented Apr 25, 2023 •
edited

From v1.10, pod volume backup will fail earlier if node-agent pod is not running in the same node where the backing up pod is running, instead of waiting until timeout (by default, 4 hours). Therefore, it does more checks about the status of backing up pod and node-agent pod. However, the checks involves an unnecessary behavior change -- if the backing up pod is not running, that pod volume backup will be marked as fail and the entire backup goes to partially failure.

This will cause the pod volume backup to namespaces with pods in completed status to keep failing.
@Lyndon-Li Lyndon-Li added this to the v1.12 milestone Apr 25, 2023
@Lyndon-Li Lyndon-Li self-assigned this Apr 25, 2023
@Lyndon-Li Lyndon-Li mentioned this issue Apr 25, 2023
Merged
@akshaysgithub akshaysgithub mentioned this issue Apr 25, 2023
Closed
This was referenced Apr 25, 2023
Merged
Merged
@Lyndon-Li
Copy link
Contributor Author

Close as completed

@Lyndon-Li Lyndon-Li mentioned this issue May 15, 2023
Closed
@Lyndon-Li Lyndon-Li mentioned this issue Jul 4, 2023
Closed
kaovilai added a commit to kaovilai/openshift-velero-plugin that referenced this issue Jul 12, 2023
@kaovilai
Remove non-working code for backing up completed build pods
0a52289 
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai kaovilai mentioned this issue Jul 12, 2023
Closed
kaovilai added a commit to kaovilai/openshift-velero-plugin that referenced this issue Jul 12, 2023
@kaovilai
Remove non-working code for backing up completed build pods
c09f232 
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai added a commit to kaovilai/openshift-velero-plugin that referenced this issue Jul 12, 2023
@kaovilai
Remove non-working code for backing up completed build pods
fd59ba3 
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai added a commit to kaovilai/openshift-velero-plugin that referenced this issue Jul 12, 2023
@kaovilai
Remove non-working code for backing up completed build pods
f048be7 
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

remove pod backup plugin from main.go
kaovilai added a commit to kaovilai/openshift-velero-plugin that referenced this issue Jul 12, 2023
@kaovilai
Remove non-working code for backing up completed build pods
a7fa408 
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

Remove non-working code for backing up completed build pods

No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

remove pod backup plugin from main.go

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@karan1ngit
Copy link

when will 1.11.1 be released?

@sseago
Copy link
Collaborator

sseago commented Jul 26, 2023

@karan1ngit 1.11.1 was just released this week.

@danfengliu danfengliu mentioned this issue Aug 4, 2023
Open
openshift-merge-robot pushed a commit to openshift/openshift-velero-plugin that referenced this issue Aug 22, 2023
@kaovilai
OADP-1057: AWS STS Creds support for internal image backup (#199)
38fd1f4 
* add support for aws sts creds for registry

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* remove image-spec replace breaking build

* OADP-1057: STS creds support for internal image backup

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* Remove non-working code for backing up completed build pods

No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

remove pod backup plugin from main.go

* Resolve Dockerfile perm issues running go build by removing specified UID when copying

Resolves
```
 > [builder 6/6] RUN go build -installsuffix "static" -tags "containers_image_ostree_stub exclude_graphdriver_devicemapper exclude_graphdriver_btrfs containers_image_openpgp exclude_graphdriver_overlay include_gcs include_oss" -o _output/velero-plugins ./velero-plugins:
#0 4.584 error obtaining VCS status: exit status 128
#0 4.584        Use -buildvcs=false to disable VCS stamping.
```

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* update go.mod to openshift/velero #276

* add sts cred secret handling

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* Pass secret path instead of web_identity_token_file

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* Update go.mod to openshift/oadp-1.2

---------

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-velero-plugin that referenced this issue Aug 22, 2023
@kaovilai
Remove non-working code for backing up completed build pods
ed997d1 
No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

remove pod backup plugin from main.go
openshift-merge-robot pushed a commit to openshift/openshift-velero-plugin that referenced this issue Aug 22, 2023
@openshift-cherrypick-robot @kaovilai
[oadp-1.2] OADP-1057: AWS STS Creds support for internal image backup (…
4a17e00 
…#202)

* add support for aws sts creds for registry

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* remove image-spec replace breaking build

* OADP-1057: STS creds support for internal image backup

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* Remove non-working code for backing up completed build pods

No longer needed after by vmware-tanzu/velero#6189 or vmware-tanzu/velero#6188 which fix vmware-tanzu/velero#6182

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

remove pod backup plugin from main.go

* Resolve Dockerfile perm issues running go build by removing specified UID when copying

Resolves
```
 > [builder 6/6] RUN go build -installsuffix "static" -tags "containers_image_ostree_stub exclude_graphdriver_devicemapper exclude_graphdriver_btrfs containers_image_openpgp exclude_graphdriver_overlay include_gcs include_oss" -o _output/velero-plugins ./velero-plugins:
#0 4.584 error obtaining VCS status: exit status 128
#0 4.584        Use -buildvcs=false to disable VCS stamping.
```

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* update go.mod to openshift/velero #276

* add sts cred secret handling

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* Pass secret path instead of web_identity_token_file

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* Update go.mod to openshift/oadp-1.2

---------

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Co-authored-by: Tiger Kaovilai <tkaovila@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lyndon-Li Lyndon-Li

Labels
area/fs-backup target/1.10.3 target/1.11.1
Projects
None yet
Milestone
v1.12
Development

Successfully merging a pull request may close this issue.

Remove non-working code for backing up completed build pods kaovilai/openshift-velero-plugin
3 participants
@sseago @karan1ngit @Lyndon-Li