Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velero backs up namespace resources in the exclude list #6752

Closed
rnarenpujari opened this issue Sep 4, 2023 · 0 comments · Fixed by #6760
Closed

Velero backs up namespace resources in the exclude list #6752

rnarenpujari opened this issue Sep 4, 2023 · 0 comments · Fixed by #6760
Assignees
Milestone

Comments

@rnarenpujari
Copy link

rnarenpujari commented Sep 4, 2023

What steps did you take and what happened:

If you take a full cluster backup and specify some namespaces under .spec.excludedNamespaces those namespaces are still backed up (I'm taking about the namespaces themselves and not the resources within the namespaces).

For example, search for "kube-system" in this backup describe output: https://pastebin.com/iLyiPZhg

This was not the behavior on 1.10.3 so perhaps a regression.

What did you expect to happen:

Excluded namespaces not to be backed up.

The following information will help us better understand what's going on:

NA

Anything else you would like to add:

NA

Environment:

  • Velero version (use velero version): 1.12 rc1
  • Velero features (use velero client config get features):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@reasonerjt reasonerjt added this to the v1.12 milestone Sep 4, 2023
@blackpiglet blackpiglet self-assigned this Sep 5, 2023
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Sep 5, 2023
Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Sep 5, 2023
Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Sep 5, 2023
Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Sep 5, 2023
Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Sep 5, 2023
Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Sep 5, 2023
Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Sep 5, 2023
Add PSA audit and warn labels.

Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Sep 5, 2023
Add PSA audit and warn labels.

Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Sep 5, 2023
Add PSA audit and warn labels.

Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Sep 5, 2023
Add PSA audit and warn labels.

Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Sep 5, 2023
Add PSA audit and warn labels.

Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Sep 6, 2023
Add PSA audit and warn labels.

Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Sep 6, 2023
Add PSA audit and warn labels.

Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet pushed a commit to blackpiglet/velero that referenced this issue Sep 6, 2023
Add PSA audit and warn labels.

Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet added a commit that referenced this issue Sep 6, 2023
[cherry-pick][release-1.12]Fix #6752: add namespace exclude check.
blackpiglet added a commit that referenced this issue Sep 6, 2023
Fix #6752: add namespace exclude check.
kaovilai pushed a commit to kaovilai/velero that referenced this issue Oct 2, 2023
Add PSA audit and warn labels.

Signed-off-by: Xun Jiang <jxun@vmware.com>
kaovilai pushed a commit to kaovilai/velero that referenced this issue Oct 2, 2023
Add PSA audit and warn labels.

Signed-off-by: Xun Jiang <jxun@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants