Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6752: add namespace exclude check. #6760

Merged
merged 1 commit into from Sep 6, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Sep 5, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Fix #6752
Add the namespace exclude check to avoid all namespaces listed in the backup.
Also, add the PSA warning and audit label to avoid prompting warning messages and audit events.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #6760 (79b810e) into main (8d3a675) will increase coverage by 0.08%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6760      +/-   ##
==========================================
+ Coverage   60.33%   60.41%   +0.08%     
==========================================
  Files         242      242              
  Lines       25992    26023      +31     
==========================================
+ Hits        15681    15721      +40     
+ Misses       9205     9197       -8     
+ Partials     1106     1105       -1     
Files Changed Coverage Δ
pkg/backup/item_collector.go 57.87% <100.00%> (-0.48%) ⬇️
pkg/install/resources.go 77.20% <100.00%> (-0.58%) ⬇️

... and 7 files with indirect coverage changes

@blackpiglet blackpiglet force-pushed the 6752_fix branch 2 times, most recently from d17423b to 95b8a27 Compare September 5, 2023 07:47
@blackpiglet blackpiglet marked this pull request as ready for review September 5, 2023 07:48
@github-actions github-actions bot requested a review from sseago September 5, 2023 07:48
Lyndon-Li
Lyndon-Li previously approved these changes Sep 5, 2023
sseago
sseago previously approved these changes Sep 5, 2023
Lyndon-Li
Lyndon-Li previously approved these changes Sep 6, 2023
Add PSA audit and warn labels.

Signed-off-by: Xun Jiang <jxun@vmware.com>
@blackpiglet blackpiglet merged commit f72afc8 into vmware-tanzu:main Sep 6, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Velero backs up namespace resources in the exclude list
4 participants