add basic plugin panic handlers #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlisia
approved these changes
Mar 12, 2019
|
LGTM! |
|
👍 will proceed with the rest. |
|
Updated the rest. Will squash before merge, and would like to do a quick manual test. |
skriss
changed the title
Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
force-pushed
the
plugin-panic-handlers
branch
from
639ea14
to
abff244
Compare
|
Squashed, test looks fine. |
nrb
suggested changes
Mar 13, 2019
Signed-off-by: Steve Kriss <krisss@vmware.com>
|
Updated all, try out squash & merge when ready |
jessestuart
pushed a commit
to jessestuart/velero
that referenced
this pull request
May 28, 2019
* add server-side panic handlers to all plugin methods Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #521
@carlisia @nrb this is a basic fix for #521. It captures any info about the panic and returns it as a normal error. Stack traces (per Andy's WIP #1119) to be added in subsequent PR(s).
If this looks reasonable for
block_store.gothen i'll add it to the other 3 plugins as well.