Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP: Implement configurable snapshot location #1375

Merged
merged 2 commits into from Apr 18, 2019
Merged

GCP: Implement configurable snapshot location #1375

merged 2 commits into from Apr 18, 2019

Conversation

ctrox
Copy link
Contributor

@ctrox ctrox commented Apr 16, 2019

This adds a new config parameter to the VolumeSnapshotLocation to set the location where GCP persistent volume snapshots are stored. I had to update the vendored google API as the field was only recently added. Also the field does not take multiple values as thought before. If you specify more than one the API responds with the following message:

googleapi: Error 413: Value for field 'snapshot.storageLocations' is too large: maximum size 1 element(s); actual size 2., fieldSizeTooLarge

The field just takes any location documented here.

Fixes #1361

@skriss
Copy link
Member

skriss commented Apr 16, 2019

Thanks @ctrox, this looks good on first glance! Were you able to successfully test both a backup and a restore?

Gopkg.lock Outdated Show resolved Hide resolved
@ctrox
Copy link
Contributor Author

ctrox commented Apr 17, 2019

Thanks @ctrox, this looks good on first glance! Were you able to successfully test both a backup and a restore?

Yes, I have tested several scenarios. For example a backup of a disk in europe-west6 to us-central and restore that again to a new disk in europe-west6-c works fine.

Just noticed that I missed adding the storageLocation for regional disks, that is now also done.

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you squash this into two commits - one for the dep updates, and then one with the actual velero code changes? thanks!

@nrb @carlisia pls review/merge when ready.

Signed-off-by: Cyrill Troxler <cyrill@nine.ch>
Signed-off-by: Cyrill Troxler <cyrill@nine.ch>
@nrb nrb merged commit b01b124 into vmware-tanzu:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP: Configurable Snapshot location
3 participants