remove all remaining legacy Ark references #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
commented
Apr 29, 2019
| @@ -58,18 +58,15 @@ var nonRestorableResources = []string{ | |||
|
|
|||
| // Don't ever restore backups - if appropriate, they'll be synced in from object storage. | |||
| // https://github.com/heptio/velero/issues/622 | |||
| "backups.ark.heptio.com", | |||
There was a problem hiding this comment.
I agree users should have, though I'm unsure that everyone will.
That said, since our controllers won't actually process anything in the old API group, the restored Ark backups will be inert, so it's not going to trigger a cascade.
There was a problem hiding this comment.
Yep, that was my thinking.
nrb
approved these changes
Apr 29, 2019
carlisia
approved these changes
Apr 29, 2019
jessestuart
pushed a commit
to jessestuart/velero
that referenced
this pull request
May 28, 2019
Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss krisss@vmware.com
I think this removes the last batch of "Ark" refs from the code, apart from docs that explicitly discuss the migration from Heptio Ark to Velero.
@nrb @carlisia