New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-1505] add documentation regarding autocompletion for velero CLI #2208
Conversation
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Thanks for this @cpanato, this is great! I tried out the macOS instructions and they worked liked a charm 👍 The only thought I have is that we might want to locate this on a different page, to avoid making the "basic install" page too cluttered. One option would be to create a new page with this info, and add a link to it right at the bottom of the "Install the CLI" section. What does everyone think? |
I agree with @skriss We might want to relocate this on the Customize-Installation page. |
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@skriss @ashish-amarnath done, please let me know your thoughts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
We should provide similar documentation for v1.2.0
@ashish-amarnath should I open another PR when this gets merge to cherry-pick this changes to the v1.2.0? |
LGTM. @cpanato to replicate this addition for the |
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@skriss done added the docs to 1.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @ashish-amarnath please take another look when you get a chance.
Thanks again @cpanato!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 💯
Add documentation in how to setup autocompletion for Velero CLI
fixes: bash completion not working on macos #1505
Instructions tested on: