Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-1505] add documentation regarding autocompletion for velero CLI #2208

Merged
merged 3 commits into from Jan 27, 2020
Merged

[GH-1505] add documentation regarding autocompletion for velero CLI #2208

merged 3 commits into from Jan 27, 2020

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Jan 17, 2020

Instructions tested on:

  • Linux Ubuntu 18.04 - bash
  • Linux Ubuntu 18.04 - zsh
  • macOS Catalina - bash
  • macOS Catalina - zsh

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@skriss
Copy link
Member

skriss commented Jan 21, 2020

Thanks for this @cpanato, this is great! I tried out the macOS instructions and they worked liked a charm 👍

The only thought I have is that we might want to locate this on a different page, to avoid making the "basic install" page too cluttered. One option would be to create a new page with this info, and add a link to it right at the bottom of the "Install the CLI" section. What does everyone think?

@ashish-amarnath
Copy link
Contributor

I agree with @skriss We might want to relocate this on the Customize-Installation page.

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato
Copy link
Contributor Author

cpanato commented Jan 22, 2020

@skriss @ashish-amarnath done, please let me know your thoughts

Copy link
Contributor

@ashish-amarnath ashish-amarnath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
We should provide similar documentation for v1.2.0

@cpanato
Copy link
Contributor Author

cpanato commented Jan 23, 2020

@ashish-amarnath should I open another PR when this gets merge to cherry-pick this changes to the v1.2.0?

@skriss
Copy link
Member

skriss commented Jan 27, 2020

LGTM. @cpanato to replicate this addition for the v1.2.0 docs, you'll need to manually apply the same changes to the docs under site/docs/v1.2.0. We usually do this in the same PR as the site/docs/master changes. Once you do that, I think we're good to merge here!

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato
Copy link
Contributor Author

cpanato commented Jan 27, 2020

@skriss done added the docs to 1.2.0
thanks for pointing out

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @ashish-amarnath please take another look when you get a chance.

Thanks again @cpanato!

Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💯

@carlisia carlisia merged commit 82d6ad4 into vmware-tanzu:master Jan 27, 2020
@cpanato cpanato deleted the GH-1505 branch January 28, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bash completion not working on macos
4 participants