wait for informer caches to sync before running controllers #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am onboard w/ the idea here 👍 |
|
@ashish-amarnath FYI, I'm hoping that this followed by #131 puts us in a better position to contemplate a potential migration to kubebuilder, since most of the processing logic will have been extracted from our controllers and put into libraries. It also sets us up to more easily move to using worker pods (one per backup/restore) if we decide to go that route. |
skriss
force-pushed
the
refactor-cache-sync
branch
from
2604ef4
to
56ab751
Compare
skriss
changed the title
|
I went ahead and updated all the controllers. Note we'll hold this until after releasing v1.3, so I'm leaving it as a draft. |
skriss
force-pushed
the
refactor-cache-sync
branch
from
56ab751
to
6b8f1c0
Compare
carlisia
previously approved these changes
Feb 26, 2020
skriss
force-pushed
the
refactor-cache-sync
branch
from
bfd910f
to
6a952f7
Compare
|
ready for review/merge now that v1.3.0 has been tagged. |
Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
force-pushed
the
refactor-cache-sync
branch
from
6a952f7
to
9f8e0ca
Compare
|
@nrb @ashish-amarnath gentle reminder that this is ready for review/merge. |
nrb
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss krisss@vmware.com
closes #616 (already closed)
@carlisia @nrb @ashish-amarnath wanted to get your input on this change before making it for all the controllers. This moves the logic that waits for informers' caches to sync out of each individual controller, and into the main server process, before running any controllers. You can see #616 for a little more detail.
I want to do this because it makes some other refactoring that I'd like to do (basically #131) easier by not requiring each struct that uses an informer/lister to wait for cache sync before using it.
If it looks good to you, I'll continue changing all the other controllers!