Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow plugins/ as a valid directory in the BSL bucket #2350

Merged
merged 2 commits into from Mar 17, 2020

Conversation

skriss
Copy link
Member

@skriss skriss commented Mar 17, 2020

Signed-off-by: Steve Kriss krisss@vmware.com

closes #2344

Signed-off-by: Steve Kriss <krisss@vmware.com>
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say a changelog would be helpful, but other than that 👍

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss
Copy link
Member Author

skriss commented Mar 17, 2020

changelog added

@skriss
Copy link
Member Author

skriss commented Mar 17, 2020

Oh, I guess the other part of this is, are we comfortable releasing this in a v1.3.2 so this directory can be used soon? I think it's fine, but we can hold off for a little bit and see if there are any other bug fixes to package up.

Copy link
Contributor

@ashish-amarnath ashish-amarnath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashish-amarnath ashish-amarnath merged commit 016df40 into vmware-tanzu:master Mar 17, 2020
@nrb
Copy link
Contributor

nrb commented Mar 18, 2020

Oh, I guess the other part of this is, are we comfortable releasing this in a v1.3.2 so this directory can be used soon?

I'm ok with that, though I think we should accumulate a few more changes since it's not really a crucial fix.

@nrb nrb added this to the v1.3.2 milestone Mar 27, 2020
@skriss skriss mentioned this pull request Apr 2, 2020
@skriss skriss deleted the allow-plugins-dir branch April 6, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow plugins to write arbitrary data to 'plugins/' directory inside backup storage location
3 participants