Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight use of TTL flag to specify backup retention #2399

Merged
merged 2 commits into from Apr 6, 2020

Conversation

rochfordk
Copy link
Contributor

@rochfordk rochfordk commented Apr 6, 2020

closes #2267

Added further TTL information to 'Set a backup to expire' section of how-velero-works.md and included links to that section from the migration and DR use-case pages

Signed-off-by: Keith <keith.rochford@gmail.com>
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @rochfordk, this looks great!

Could you duplicate these changes under site/docs/master as well? They're needed in both places in order to be visible in the current version's docs, and to be carried forward to future versions as well.

@rochfordk
Copy link
Contributor Author

Thanks @skriss , those same changes made to the /master docs as well now. I'll get the hang of this yet!

Signed-off-by: Keith <keith.rochford@gmail.com>
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nrb nrb merged commit fffed56 into vmware-tanzu:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Velero snapshot retention Policies: No available documentation?
3 participants