Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping validation for volumesnapshotlocation for backup if snapshotvolume set to false #2450

Merged
merged 3 commits into from Apr 24, 2020
Merged

Skipping validation for volumesnapshotlocation for backup if snapshotvolume set to false #2450

merged 3 commits into from Apr 24, 2020

Conversation

mynktl
Copy link
Contributor

@mynktl mynktl commented Apr 22, 2020 •
edited

Changes:

  • If backup has snapshotvolume then validateAndGetSnapshotLocations skip validating VSL and returns empty VSL list with success.

Existing behavior:

  • if velero is configured with multiple VSL with the same provider but no default VSL configured, then one needs to provide VSL during backup creation, with snapshotvolume disabled, otherwise backup will fail with status.phase FailedValidation.

If one wants to use restic for the volume backup then he/she doesn't need to provide VSL for the backup.

Signed-off-by: mayank mayank.patel@mayadata.io

@mynktl mynktl marked this pull request as draft April 22, 2020 19:26
Disabling validation for volumesnapshotlocation if the backup has sna…
dc9570a 
…pshotvolume set to false

Signed-off-by: mayank <mayank.patel@mayadata.io>
@mynktl mynktl changed the title Disabling validation for volumesnapshotlocation for backup if snapshotvolume set to false Skipping validation for volumesnapshotlocation for backup if snapshotvolume set to false Apr 23, 2020
@mynktl mynktl marked this pull request as ready for review April 23, 2020 10:50
adding a changelog
4ee5de7 
Signed-off-by: mayank <mayank.patel@mayadata.io>
ashish-amarnath
ashish-amarnath suggested changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@ashish-amarnath ashish-amarnath left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one minor comment suggesting to use some of the helper functions that we have.

addressing review comment
1f70182 
Signed-off-by: mayank <mayank.patel@mayadata.io>
@mynktl
Copy link
Contributor Author

mynktl commented Apr 24, 2020

Hi @ashish-amarnath
I've updated the changes according to review comment. PTAL.
Thanks!

skriss
skriss approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Thanks for adding the test cases!

ashish-amarnath
ashish-amarnath approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@ashish-amarnath ashish-amarnath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ashish-amarnath ashish-amarnath merged commit 962f5d6 into vmware-tanzu:master Apr 24, 2020
@mynktl mynktl deleted the restic branch April 24, 2020 17:22
@skriss skriss mentioned this pull request May 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skriss skriss skriss approved these changes

@ashish-amarnath ashish-amarnath ashish-amarnath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mynktl @skriss @ashish-amarnath