Add documentation for --cacert feature #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
|
@mansam the content looks great, thanks for writing this up. Per @carlisia & @nrb's original suggestion, let's add a link to this page in the nav bar under "Use" -- somewhere in this section. I think we should probably also link to it from https://github.com/vmware-tanzu/velero/blob/master/site/docs/master/customize-installation.md -- you can do something similar to the Install in any namespace section. Adding others for review, but once those links are added, LGTM |
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
ashish-amarnath
approved these changes
Apr 29, 2020
twoequaldots
pushed a commit
to twoequaldots/velero
that referenced
this pull request
Apr 30, 2020
* Add documentation for --cacert feature Signed-off-by: Sam Lucidi <slucidi@redhat.com> * Document objectStorage/caCert field. Signed-off-by: Sam Lucidi <slucidi@redhat.com> * Add link to ca bundle docs in TOC and customize-installation Signed-off-by: Sam Lucidi <slucidi@redhat.com> Signed-off-by: David Colon <dave@colon.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is documentation for the
--cacertfeature added in the following PRs:#2353
#2364
#2368
@skriss Please let me know if you think this is sufficient or needs to be expanded.
Fixes #2396