Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating governance for Velero - WIP #2541

Merged
merged 10 commits into from May 29, 2020
Merged

updating governance for Velero - WIP #2541

merged 10 commits into from May 29, 2020

Conversation

michmike
Copy link
Contributor

Signed-off-by: Michael Michael michmike@cs.stanford.edu

Signed-off-by: Michael Michael <michmike@cs.stanford.edu>
Signed-off-by: Michael Michael <michmike@cs.stanford.edu>
Signed-off-by: Michael Michael <michmike@cs.stanford.edu>
Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, but I'll review more throughly on Mon. Couple questions for now.

MAINTAINERS.md Show resolved Hide resolved
MAINTAINERS.md Outdated Show resolved Hide resolved
Signed-off-by: Michael Michael <michmike@cs.stanford.edu>
GOVERNANCE.md Outdated Show resolved Hide resolved
MAINTAINERS.md Outdated Show resolved Hide resolved
Signed-off-by: Michael Michael <michmike@cs.stanford.edu>
Signed-off-by: Michael Michael <michmike@cs.stanford.edu>
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for this; had a few comments and questions

GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Show resolved Hide resolved
GOVERNANCE.md Show resolved Hide resolved
GOVERNANCE.md Show resolved Hide resolved
MAINTAINERS.md Show resolved Hide resolved
design/_template.md Outdated Show resolved Hide resolved
MAINTAINERS.md Show resolved Hide resolved

* **Users:** Members that engage with the Velero community via any medium (Slack, GitHub, mailing lists, etc.).
* **Contributors:** Regular contributions to projects (documentation, code reviews, responding to issues, participation in proposal discussions, contributing code, etc.).
* **Maintainers**: The Velero project leaders. They are responsible for the overall health and direction of the project; final reviewers of PRs and responsible for releases. Some Maintainers are responsible for one or more components within a project, acting as technical leads for that component. Maintainers are expected to contribute code and documentation, review PRs including ensuring quality of code, triage issues, proactively fix bugs, and perform maintenance tasks for these components.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should technical/feature leads be another role, a step forward from Contributors towards becoming a maintainer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you be more specific as to what makes that role more distinct from a contributor or maintainer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is like giving a category to the Feature leads (Stake holders) that are mentioned here: https://github.com/vmware-tanzu/velero/blob/a86079220173c4e7f5f9dead9aa5857ba77ba758/MAINTAINERS.md#velero-contributors--stakeholders

The journey could be:
Contributors -> Leads/Stake holders -> Maintainers

As the load/backlog on the Maintainers increases, Maintainers could nominate one of the Contributors who are familiar with a certain feature/area and have significantly contributed to that area to become a Lead/Stake Holder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmova that's a good suggestion. others what do you think?
cc: @vmware-tanzu/velero-maintainers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is worth talking about "face-to-face" in our community meeting.

Initially my question is, other than on-paper recognition (which I'm all for), how would this role be different than a maintainer, in practical terms?

@carlisia carlisia merged commit 0f934bc into master May 29, 2020
@carlisia carlisia deleted the michmike-patch-1 branch May 29, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants