don't error during backup when additional items returned by plugin don't exist #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
nrb
approved these changes
Jun 4, 2020
| d.Printf("Errors:\t%d\n", status.Errors) | ||
| d.Printf("Warnings:\t%d\n", status.Warnings) | ||
| } | ||
| d.Println() |
There was a problem hiding this comment.
I like this change. It is a good step towards unifying restore and backup describe output. (cc @sseago)
There was a problem hiding this comment.
Yeah I tried to be consistent between the two, it's a lot easier for users that way.
ashish-amarnath
approved these changes
Jun 4, 2020
nrb
pushed a commit
to nrb/velero
that referenced
this pull request
Jul 13, 2020
…n't exist (vmware-tanzu#2595) * log a warning instead of erroring if additional item can't be found Signed-off-by: Steve Kriss <krisss@vmware.com> * always show backup warning/error count in get/describe Signed-off-by: Steve Kriss <krisss@vmware.com> * changelog Signed-off-by: Steve Kriss <krisss@vmware.com>
ashish-amarnath
added a commit
that referenced
this pull request
Jul 13, 2020
* setup ci in github actions Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * remove travis config Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * Add changelog for v1.4.2 Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * update build status badge on readme Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * don't error during backup when additional items returned by plugin don't exist (#2595) * log a warning instead of erroring if additional item can't be found Signed-off-by: Steve Kriss <krisss@vmware.com> * always show backup warning/error count in get/describe Signed-off-by: Steve Kriss <krisss@vmware.com> * changelog Signed-off-by: Steve Kriss <krisss@vmware.com> * Update changelogs Signed-off-by: Nolan Brubaker <brubakern@vmware.com> Co-authored-by: Ashish Amarnath <ashisham@vmware.com> Co-authored-by: Steve Kriss <krisss@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1878
closes #2269
This PR changes the backup code to log a warning instead of returning an error if an additional item returned by a backup item action plugin can't be found in the Kubernetes API. It also changes
velero backup get/describeto always display warning/error count, rather than doing it selectively based on phase.