Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when a hook timeout duration can't be parsed #2610

Merged
merged 1 commit into from Jun 5, 2020

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Jun 4, 2020

Fixes #2599

This doesn't fundamentally change behavior, but surfaces the behavior for the user.

Signed-off-by: Nolan Brubaker brubakern@vmware.com

@nrb nrb added Bug Enhancement/User End-User Enhancement to Velero labels Jun 4, 2020
@nrb nrb requested review from skriss and a team June 4, 2020 21:19
@nrb nrb self-assigned this Jun 4, 2020
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for clearing that // TODO :)

Copy link
Contributor

@ashish-amarnath ashish-amarnath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ashish-amarnath ashish-amarnath merged commit d9d9dc6 into vmware-tanzu:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Enhancement/User End-User Enhancement to Velero
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timeout on pre hook error
3 participants