Add a BSL controller to handle validation + update BSL status phase

[carlisia]

Closes: #1967.

Specs are on the ticket.

Note: I will add validation to BSL create/update in a separate PR.

Signed-off-by: Carlisia carlisia@vmware.com

[ashish-amarnath]

This is looking good just added some comments.

[ashish-amarnath]

Did a quick pass and the code LGTM.
Going to take another look tomorrow with a fresher pair of 👀

Were you able to run this with multiple BSLs and also verify that the BSLs are correctly reconciled?

[carlisia]

Were you able to run this with multiple BSLs and also verify that the BSLs are correctly reconciled?

Yes. Scenarios (and shifting from one to the other):

• 0 BSLs
• storage down
• multiple, all valid
• multiple, all invalid
• only 1, invalid
• only 1, valid
• multiple, none of which were the specified default

[nrb]

Overall, I think this is pretty much ready! I have some questions on it, but I think that's all at this point.

[ashish-amarnath]

Thanks for your patience @carlisia.
Will have faster turnaround on the next review.
I have another round of comments.

[ashish-amarnath]

Isn't DefaultStoreValidationFrequency == 0 a way to disable this periodic validation?

[nrb]

Ah, yeah, this should probably just look for < 0

[carlisia]

Good catch. And no validation should be in the controller anyway, removing.

In the business logic there's already:

	if validationFrequency < 0 {
		log.Debugf("Validation period must be non-negative, changing from %d to %d", validationFrequency, p.DefaultStoreValidationFrequency)
		validationFrequency = p.DefaultStoreValidationFrequency
	}
	

[nrb]

We're close! I think the question about what we do when there are 0 BSLs, whether on startup or during runtime, is an important one. I've got some comments and questions inline that I'd like to understand before deciding how we proceed there.

I think I'd like to lean towards not halting the server when there's no BSLs, in order to help folks who are trying to run Velero as part of a larger system.

[ashish-amarnath]

LGTM 🚀