New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a BSL controller to handle validation + update BSL status phase #2674
Conversation
51eeb48
to
7fbbdac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good just added some comments.
e73449b
to
a24411d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick pass and the code LGTM.
Going to take another look tomorrow with a fresher pair of 👀
Were you able to run this with multiple BSLs and also verify that the BSLs are correctly reconciled?
Yes. Scenarios (and shifting from one to the other):
|
a24411d
to
69fbb60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think this is pretty much ready! I have some questions on it, but I think that's all at this point.
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
69fbb60
to
8cd2193
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience @carlisia.
Will have faster turnaround on the next review.
I have another round of comments.
log.WithError(err).Error("No backup storage locations found, at least one is required") | ||
} | ||
|
||
if r.StorageLocation.DefaultStoreValidationFrequency <= 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't DefaultStoreValidationFrequency == 0
a way to disable this periodic validation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yeah, this should probably just look for < 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. And no validation should be in the controller anyway, removing.
In the business logic there's already:
if validationFrequency < 0 {
log.Debugf("Validation period must be non-negative, changing from %d to %d", validationFrequency, p.DefaultStoreValidationFrequency)
validationFrequency = p.DefaultStoreValidationFrequency
}
Signed-off-by: Carlisia <carlisia@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're close! I think the question about what we do when there are 0 BSLs, whether on startup or during runtime, is an important one. I've got some comments and questions inline that I'd like to understand before deciding how we proceed there.
I think I'd like to lean towards not halting the server when there's no BSLs, in order to help folks who are trying to run Velero as part of a larger system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Closes: #1967.
Specs are on the ticket.
Note: I will add validation to BSL create/update in a separate PR.
Signed-off-by: Carlisia carlisia@vmware.com