🐛 Use CRD version prior to remap_crd_version backup item action #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR looked good in testing against a kubernetes 1.17. Going to run more tests. |
ashish-amarnath
force-pushed
the
preserve-crd-version
branch
from
5884a59
to
07e4cfe
Compare
|
Verified this PR on |
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
ashish-amarnath
force-pushed
the
preserve-crd-version
branch
from
07e4cfe
to
0af3541
Compare
ashish-amarnath
changed the title
|
@ashish-amarnath Did you try this against versions lower than 1.17, too? Also, what other CRDs did you test against? We probably want a few different ones to verify against, just to be sure we get a representative sample size. |
nrb
reviewed
Jul 6, 2020
|
Verified this PR on KIND_IMAGE_VERSIONS=("kindest/node:v1.16.9" "kindest/node:v1.17.0" "kindest/node:v1.18.4") I used the executionhook and hookaction CR from https://github.com/kubernetes-sigs/execution-hook/pull/5/files. |
nrb
approved these changes
Jul 7, 2020
|
@carlisia PTAL. Thanks! |
1 task
nrb
pushed a commit
to nrb/velero
that referenced
this pull request
Jul 13, 2020
…re-tanzu#2683) * 🐛 preserve crd version before remapping Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
ashish-amarnath
added a commit
that referenced
this pull request
Jul 13, 2020
* Adjust restic timeout and pod values up (#2696) * Adjust restic timeout and pod values up Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * 🐛 Use CRD version prior to remap_crd_version backup item action (#2683) * 🐛 preserve crd version before remapping Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * 🏃♂️ pass git state to build from makefile Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * Add scripts for tagging Velero releases (#2592) * Add release tools Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Document the tag-release release tool Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Make sure the upstream used is correct Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Add copyright statement Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Address review feedback * Pause to allow for cherry-picking on the release branch before pushing it * Move master branch logic into an else statement * Correct typo Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Uncomment check for dirty git working tree Signed-off-by: Nolan Brubaker <brubakern@vmware.com> Co-authored-by: Ashish Amarnath <ashisham@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashish Amarnath ashisham@vmware.com
Fixes: #2682
Captures the version of the CRD before the
remap_crd_versionbackup item action plugin updates the version.This ensures that check at item_backupper.go#L253 is satisfied and that the manifest in the backup is persisted under
<BACKUP_ROOT>/resource/customresourcedefinitions.apiextensions.k8s.io/clusterwhere it is expected to restore correctly