Add Tilt configs

[carlisia]

Closes #2501.

This is what it looks like with everything enabled. Any change to the Velero/restic server or any of the plugins is reflected in the logs within seconds:

Signed-off-by: Carlisia carlisia@vmware.com

[nrb]

If this works, I think we could update the build.sh script to make the GIT_SHA optional, or look up the value in the Tiltfile once at the start.

That way, the value's not hardcoded to something that may confuse a dev looking at their binary someday and wondering why the built SHA doesn't match what they're actually building.

[carlisia]

This worked. I have to do the same with the plugin bit.

Ok, I'll changed the build.sh.

Should PKG be set to github.com/vmware-tanzu/velero or to where the local src code is?

[carlisia]

I'm pointing the PKG variable to local code. Let me know if it should be different.

Changes made

[carlisia]

Ready for review.

[carlisia]

Made some improvements:

• changed .tiltbuild to _tiltbuild
• added a separate local build to build a binary for the user's machine (this way we don't need to run make local when making changes to the CLI
• added a config to pass in the user's local goos
• renamed the Tilt resources to be more meaningful and shorter
• added a tip to the documentation to create an alias to the user's local binary included above

[carlisia]

A note: for the plugins, I am also now making a call to the plugin hack/build.sh: https://github.com/vmware-tanzu/velero/pull/3119/files#diff-c2ee8653e1d6b85f0aadf87cd438a9250806c052877248442be4d434cbc52425R178

However, plugins maintained by others might not have this build setup and, if they don't, this will fail. Should I change to call go build inline for this case?

Other than this, it's ready for review.

[nrb]

However, plugins maintained by others might not have this build setup and, if they don't, this will fail. Should I change to call go build inline for this case?

We could, though it's worth asking if we're making this universal, or for core development. Another option is to say that if you want to use the Tiltfile for development the hack/build.sh entrypoint is necessary, which may not be so bad anyway - consider that even if we do plain go build, each plugin might have their own settings/flags that they want to introduce at build time. Maybe they really want CGO turned on. By using a script name vs a bare command in the Tiltfile, they would have a way to include those settings without editing the Tiltfile.

[carlisia]

consider that even if we do plain go build, each plugin might have their own settings/flags that they want to introduce at build time

This is a winning argument. And it is also not bad at all since 1, we have examples and 2, it's such a simple and small file.

So, let's 🚢 this!

[zubron]

This is really awesome so far, @carlisia! I'm still working on a review but I have some questions/comments in the meantime :)

[zubron]

It's not necessary or a blocker, but it would be nice to get the PRs for the plugin repos merged first so that the tl;dr above works out of the box. I made the mistake of following that without checking out the plugin repo PRs with their tilt settings.

[zubron]

I'm leaving this comment here as a note for others that we should get the other PRs reviewed and merged first :)

[carlisia]

This is ready for review again.

[zubron]

Woo! Thank you so much for this, @carlisia!! This is an awesome change and I'm looking forward to using it 🤩

[ashish-amarnath]

LGTM! 🚢

[zubron]

🥳