Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support set BackupStorageLocation(BSL) CA certificate #3167

Merged
merged 5 commits into from
Feb 8, 2021
Merged

feat: support set BackupStorageLocation(BSL) CA certificate #3167

merged 5 commits into from
Feb 8, 2021

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Dec 9, 2020 •
edited
Loading

Add a new flag --cacert under velero backup-location set to allow configures the CA certificate of BSL.

In velero install and velero backup-location create, the flag is --cacert.
To make it compatible, change the CLI design doc from --cacert-file to --cacert.

The only drawback of this new flag proposal is that the user can't remove the cacert setting from velero CLI directly if the BSL changes it's setting from w/ TLS to w/o TLS.

partial fixes #2425
ref to #2419

JenTing Hsiao added 3 commits December 9, 2020 11:36
Rename --cacert-file to --cacert in the CLI design doc
0dec8c7 
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Add a new flag --cacert under velero backup-location set
6577844 
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Add changelog
cc47a25 
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
@jenting jenting marked this pull request as ready for review December 9, 2020 04:49
carlisia
carlisia previously approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it works.

Good point about not being able to remove the TLS from Velero. They'd need to edit the BSL CRD or delete it/recreate it. Maybe we can add a cmd for this later.

@carlisia carlisia mentioned this pull request Dec 10, 2020
Closed
3 tasks
nrb
nrb reviewed Dec 15, 2020
View reviewed changes
design/cli-install-changes.md Outdated Show resolved Hide resolved
nrb
nrb suggested changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple minor changes that I'd request - rewording the changelog entry and removing the edits to the design doc, which aren't strictly necessary.

changelogs/unreleased/3167-jenting Outdated Show resolved Hide resolved
@carlisia carlisia added this to the v1.6.0 milestone Dec 15, 2020
JenTing Hsiao added 2 commits December 15, 2020 15:20
Changelog rewording
0046e41 
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Revert CLI design doc
6467e5d 
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
zubron
zubron approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@zubron zubron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jenting jenting added the Area/CLI related to the command-line interface label Jan 7, 2021
@nrb nrb merged commit e115949 into vmware-tanzu:main Feb 8, 2021
@jenting jenting deleted the set-bsl-cacert branch February 8, 2021 22:42
dharmab pushed a commit to dharmab/velero that referenced this pull request May 25, 2021
@dharmab
feat: support set BackupStorageLocation(BSL) CA certificate (vmware-t…
845e5aa 
…anzu#3167)

* Rename --cacert-file to --cacert in the CLI design doc

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Add a new flag --cacert under `velero backup-location set`

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Add changelog

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Changelog rewording

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Revert CLI design doc

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
ywk253100 pushed a commit to ywk253100/velero that referenced this pull request Jun 29, 2021
@ywk253100
feat: support set BackupStorageLocation(BSL) CA certificate (vmware-t…
2fdc81e 
…anzu#3167)

* Rename --cacert-file to --cacert in the CLI design doc

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Add a new flag --cacert under `velero backup-location set`

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Add changelog

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Changelog rewording

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Revert CLI design doc

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this pull request May 14, 2022
@gyaozhou
feat: support set BackupStorageLocation(BSL) CA certificate (vmware-t…
991f34e 
…anzu#3167)

* Rename --cacert-file to --cacert in the CLI design doc

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Add a new flag --cacert under `velero backup-location set`

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Add changelog

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Changelog rewording

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Revert CLI design doc

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrb nrb nrb approved these changes

@zubron zubron zubron approved these changes

@ashish-amarnath ashish-amarnath Awaiting requested review from ashish-amarnath

@dsu-igeek dsu-igeek Awaiting requested review from dsu-igeek

@carlisia carlisia Awaiting requested review from carlisia

Assignees

@jenting jenting

Labels
Area/CLI related to the command-line interface
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Improve the velero backup-location command
4 participants
@jenting @carlisia @nrb @zubron