Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support fish shell completion #3231

Merged
merged 6 commits into from Jan 25, 2021
Merged

Support fish shell completion #3231

merged 6 commits into from Jan 25, 2021

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Jan 12, 2021 •
edited

As fish shell supported at spf13/cobra v1.0.0 release, bump spf13/cobra package version to current latest version v1.1.1 to support fish shell completion for Velero.

The code change reference to https://github.com/spf13/cobra/blob/v1.1.1/shell_completions.md

fixes #3281

JenTing Hsiao added 4 commits January 12, 2021 22:37
Support fish shell completion
e8c595f 
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Use spf13/cobra library to generate zsh completion
ce367e1 
reference to https://github.com/spf13/cobra/blob/v1.1.1/shell_completions.md

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Update velero completion help message
c42368d 
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Add changelog
e16ae58 
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
@jenting jenting marked this pull request as ready for review January 12, 2021 15:05
zubron
zubron suggested changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@zubron zubron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. Thanks for updating the instructions as well. Just a couple of things that
need to be changed before it can be merged. It's worth noting that this will fix #3281 (opened after this PR).

go.mod Outdated Show resolved Hide resolved
pkg/cmd/cli/completion/completion.go Outdated Show resolved Hide resolved
@jenting jenting linked an issue Jan 18, 2021 that may be closed by this pull request
Add completion for the fish shell #3281
Closed
Update cobra version in go.mod instead of replace
2d16254 
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
@jenting jenting added the Area/CLI related to the command-line interface label Jan 18, 2021
@github-actions github-actions bot requested a review from zubron January 18, 2021 22:34
zubron
zubron suggested changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@zubron zubron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, @jenting! This looks good to me but there is a local file accidentally included in this. Once that's removed, it'll be ready to merge :)

credentials-velero Outdated Show resolved Hide resolved
Replace yourprogram to velero
78dcfe0 
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
@github-actions github-actions bot requested a review from zubron January 21, 2021 23:09
zubron
zubron approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@zubron zubron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zubron zubron merged commit 8702911 into vmware-tanzu:main Jan 25, 2021
@jenting jenting deleted the fish-shell-completion branch January 25, 2021 23:08
dharmab pushed a commit to dharmab/velero that referenced this pull request May 25, 2021
@dharmab
Support fish shell completion (vmware-tanzu#3231)
d1fc067 
* Support fish shell completion

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Use spf13/cobra library to generate zsh completion

reference to https://github.com/spf13/cobra/blob/v1.1.1/shell_completions.md

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Update velero completion help message

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Add changelog

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Update cobra version in go.mod instead of replace

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Replace yourprogram to velero

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
ywk253100 pushed a commit to ywk253100/velero that referenced this pull request Jun 29, 2021
@ywk253100
Support fish shell completion (vmware-tanzu#3231)
8ca277a 
* Support fish shell completion

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Use spf13/cobra library to generate zsh completion

reference to https://github.com/spf13/cobra/blob/v1.1.1/shell_completions.md

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Update velero completion help message

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Add changelog

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Update cobra version in go.mod instead of replace

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Replace yourprogram to velero

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this pull request May 14, 2022
@gyaozhou
Support fish shell completion (vmware-tanzu#3231)
4d56aa7 
* Support fish shell completion

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Use spf13/cobra library to generate zsh completion

reference to https://github.com/spf13/cobra/blob/v1.1.1/shell_completions.md

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Update velero completion help message

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Add changelog

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Update cobra version in go.mod instead of replace

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Replace yourprogram to velero

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrb nrb nrb approved these changes

@zubron zubron zubron approved these changes

@ashish-amarnath ashish-amarnath Awaiting requested review from ashish-amarnath

@carlisia carlisia Awaiting requested review from carlisia

@dsu-igeek dsu-igeek Awaiting requested review from dsu-igeek

Assignees

@jenting jenting

Labels
Area/CLI related to the command-line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add completion for the fish shell
3 participants
@jenting @nrb @zubron